Author: ian
Date: Wed Sep  3 17:51:03 2014
New Revision: 271046
URL: http://svnweb.freebsd.org/changeset/base/271046

Log:
  Fixes and enhancements for the if_cgem driver...
  
  - miibus fixes as suggested by Yonghyeon Pyun.
  - enable VLAN MTU support.
  - fix a few WITNESS complaints in cgem_attach().
  - have cgem_attach() properly init the ifnet struct before calling
    mii_attach() to fix panic when using e1000phy.
  - fix ethernet address changing.
  - fix transmit queue overflow handling.
  - tweak receive queue handling to reduce receive overflows.
  - bring out MAC statistic counters to sysctls.
  - add e1000phy to config file.
  - implement receive hang work-around described in reference guide.
  - change device name from if_cgem to cgem to be consistent with other
    interfaces.
  
  Submitted by: Thomas Skibo <thomassk...@sbcglobal.net>
  Reviewed by:  wkoszek, Yonghyeon PYUN <pyu...@gmail.com>

Modified:
  head/sys/arm/conf/ZEDBOARD
  head/sys/arm/xilinx/files.zynq7
  head/sys/dev/cadence/if_cgem.c
  head/sys/dev/cadence/if_cgem_hw.h

Modified: head/sys/arm/conf/ZEDBOARD
==============================================================================
--- head/sys/arm/conf/ZEDBOARD  Wed Sep  3 17:32:17 2014        (r271045)
+++ head/sys/arm/conf/ZEDBOARD  Wed Sep  3 17:51:03 2014        (r271046)
@@ -72,8 +72,9 @@ options       KDB
 device         loop
 device         random
 device         ether
-device         if_cgem                 # Zynq-7000 gig ethernet device
+device         cgem                    # Zynq-7000 gig ethernet device
 device         mii
+device         e1000phy
 device         pty
 device         uart
 device         gpio

Modified: head/sys/arm/xilinx/files.zynq7
==============================================================================
--- head/sys/arm/xilinx/files.zynq7     Wed Sep  3 17:32:17 2014        
(r271045)
+++ head/sys/arm/xilinx/files.zynq7     Wed Sep  3 17:51:03 2014        
(r271046)
@@ -23,7 +23,7 @@ arm/xilinx/zy7_slcr.c                         standard
 arm/xilinx/zy7_devcfg.c                                standard
 arm/xilinx/zy7_mp.c                            optional smp
 
-dev/cadence/if_cgem.c                          optional if_cgem
+dev/cadence/if_cgem.c                          optional cgem
 dev/sdhci/sdhci_fdt.c                          optional sdhci
 arm/xilinx/zy7_ehci.c                          optional ehci
 arm/xilinx/uart_dev_cdnc.c                     optional uart

Modified: head/sys/dev/cadence/if_cgem.c
==============================================================================
--- head/sys/dev/cadence/if_cgem.c      Wed Sep  3 17:32:17 2014        
(r271045)
+++ head/sys/dev/cadence/if_cgem.c      Wed Sep  3 17:51:03 2014        
(r271046)
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2012-2014 Thomas Skibo
+ * Copyright (c) 2012-2014 Thomas Skibo <thomassk...@yahoo.com>
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -82,17 +82,17 @@ __FBSDID("$FreeBSD$");
 
 #define IF_CGEM_NAME "cgem"
 
-#define CGEM_NUM_RX_DESCS      256     /* size of receive descriptor ring */
-#define CGEM_NUM_TX_DESCS      256     /* size of transmit descriptor ring */
+#define CGEM_NUM_RX_DESCS      512     /* size of receive descriptor ring */
+#define CGEM_NUM_TX_DESCS      512     /* size of transmit descriptor ring */
 
 #define MAX_DESC_RING_SIZE (MAX(CGEM_NUM_RX_DESCS*sizeof(struct cgem_rx_desc),\
                                CGEM_NUM_TX_DESCS*sizeof(struct cgem_tx_desc)))
 
 
 /* Default for sysctl rxbufs.  Must be < CGEM_NUM_RX_DESCS of course. */
-#define DEFAULT_NUM_RX_BUFS    64      /* number of receive bufs to queue. */
+#define DEFAULT_NUM_RX_BUFS    256     /* number of receive bufs to queue. */
 
-#define TX_MAX_DMA_SEGS                4       /* maximum segs in a tx mbuf 
dma */
+#define TX_MAX_DMA_SEGS                8       /* maximum segs in a tx mbuf 
dma */
 
 #define CGEM_CKSUM_ASSIST      (CSUM_IP | CSUM_TCP | CSUM_UDP | \
                                 CSUM_TCP_IPV6 | CSUM_UDP_IPV6)
@@ -102,6 +102,7 @@ struct cgem_softc {
        struct mtx              sc_mtx;
        device_t                dev;
        device_t                miibus;
+       u_int                   mii_media_active;       /* last active media */
        int                     if_old_flags;
        struct resource         *mem_res;
        struct resource         *irq_res;
@@ -124,7 +125,11 @@ struct cgem_softc {
        int                     rxring_queued;  /* how many rcv bufs queued */
        bus_dmamap_t            rxring_dma_map;
        int                     rxbufs;         /* tunable number rcv bufs */
-       int                     rxoverruns;     /* rx ring overruns */
+       int                     rxhangwar;      /* rx hang work-around */
+       u_int                   rxoverruns;     /* rx overruns */
+       u_int                   rxnobufs;       /* rx buf ring empty events */
+       u_int                   rxdmamapfails;  /* rx dmamap failures */
+       uint32_t                rx_frames_prev;
 
        /* transmit descriptor ring */
        struct cgem_tx_desc     *txring;
@@ -135,6 +140,56 @@ struct cgem_softc {
        int                     txring_tl_ptr;  /* next xmit mbuf to free */
        int                     txring_queued;  /* num xmits segs queued */
        bus_dmamap_t            txring_dma_map;
+       u_int                   txfull;         /* tx ring full events */
+       u_int                   txdefrags;      /* tx calls to m_defrag() */
+       u_int                   txdefragfails;  /* tx m_defrag() failures */
+       u_int                   txdmamapfails;  /* tx dmamap failures */
+
+       /* hardware provided statistics */
+       struct cgem_hw_stats {
+               uint64_t                tx_bytes;
+               uint32_t                tx_frames;
+               uint32_t                tx_frames_bcast;
+               uint32_t                tx_frames_multi;
+               uint32_t                tx_frames_pause;
+               uint32_t                tx_frames_64b;
+               uint32_t                tx_frames_65to127b;
+               uint32_t                tx_frames_128to255b;
+               uint32_t                tx_frames_256to511b;
+               uint32_t                tx_frames_512to1023b;
+               uint32_t                tx_frames_1024to1536b;
+               uint32_t                tx_under_runs;
+               uint32_t                tx_single_collisn;
+               uint32_t                tx_multi_collisn;
+               uint32_t                tx_excsv_collisn;
+               uint32_t                tx_late_collisn;
+               uint32_t                tx_deferred_frames;
+               uint32_t                tx_carrier_sense_errs;
+
+               uint64_t                rx_bytes;
+               uint32_t                rx_frames;
+               uint32_t                rx_frames_bcast;
+               uint32_t                rx_frames_multi;
+               uint32_t                rx_frames_pause;
+               uint32_t                rx_frames_64b;
+               uint32_t                rx_frames_65to127b;
+               uint32_t                rx_frames_128to255b;
+               uint32_t                rx_frames_256to511b;
+               uint32_t                rx_frames_512to1023b;
+               uint32_t                rx_frames_1024to1536b;
+               uint32_t                rx_frames_undersize;
+               uint32_t                rx_frames_oversize;
+               uint32_t                rx_frames_jabber;
+               uint32_t                rx_frames_fcs_errs;
+               uint32_t                rx_frames_length_errs;
+               uint32_t                rx_symbol_errs;
+               uint32_t                rx_align_errs;
+               uint32_t                rx_resource_errs;
+               uint32_t                rx_overrun_errs;
+               uint32_t                rx_ip_hdr_csum_errs;
+               uint32_t                rx_tcp_csum_errs;
+               uint32_t                rx_udp_csum_errs;
+       } stats;
 };
 
 #define RD4(sc, off)           (bus_read_4((sc)->mem_res, (off)))
@@ -161,6 +216,8 @@ static int cgem_detach(device_t dev);
 static void cgem_tick(void *);
 static void cgem_intr(void *);
 
+static void cgem_mediachange(struct cgem_softc *, struct mii_data *);
+
 static void
 cgem_get_mac(struct cgem_softc *sc, u_char eaddr[])
 {
@@ -197,10 +254,16 @@ cgem_get_mac(struct cgem_softc *sc, u_ch
                              "random: %02x:%02x:%02x:%02x:%02x:%02x\n",
                              eaddr[0], eaddr[1], eaddr[2],
                              eaddr[3], eaddr[4], eaddr[5]);
+       }
 
-               WR4(sc, CGEM_SPEC_ADDR_LOW(0), (eaddr[3] << 24) |
-                   (eaddr[2] << 16) | (eaddr[1] << 8) | eaddr[0]);
-               WR4(sc, CGEM_SPEC_ADDR_HI(0), (eaddr[5] << 8) | eaddr[4]);
+       /* Move address to first slot and zero out the rest. */
+       WR4(sc, CGEM_SPEC_ADDR_LOW(0), (eaddr[3] << 24) |
+           (eaddr[2] << 16) | (eaddr[1] << 8) | eaddr[0]);
+       WR4(sc, CGEM_SPEC_ADDR_HI(0), (eaddr[5] << 8) | eaddr[4]);
+
+       for (i = 1; i < 4; i++) {
+               WR4(sc, CGEM_SPEC_ADDR_LOW(i), 0);
+               WR4(sc, CGEM_SPEC_ADDR_HI(i), 0);
        }
 }
 
@@ -426,7 +489,7 @@ cgem_fill_rqueue(struct cgem_softc *sc)
                if (bus_dmamap_load_mbuf_sg(sc->mbuf_dma_tag, 
                              sc->rxring_m_dmamap[sc->rxring_hd_ptr], m,
                              segs, &nsegs, BUS_DMA_NOWAIT)) {
-                       /* XXX: warn? */
+                       sc->rxdmamapfails++;
                        m_free(m);
                        break;
                }
@@ -455,12 +518,14 @@ static void
 cgem_recv(struct cgem_softc *sc)
 {
        struct ifnet *ifp = sc->ifp;
-       struct mbuf *m;
+       struct mbuf *m, *m_hd, **m_tl;
        uint32_t ctl;
 
        CGEM_ASSERT_LOCKED(sc);
 
        /* Pick up all packets in which the OWN bit is set. */
+       m_hd = NULL;
+       m_tl = &m_hd;
        while (sc->rxring_queued > 0 &&
               (sc->rxring[sc->rxring_tl_ptr].addr & CGEM_RXDESC_OWN) != 0) {
 
@@ -497,7 +562,7 @@ cgem_recv(struct cgem_softc *sc)
                        continue;
                }
 
-               /* Hand it off to upper layers. */
+               /* Ready it to hand off to upper layers. */
                m->m_data += ETHER_ALIGN;
                m->m_len = (ctl & CGEM_RXDESC_LENGTH_MASK);
                m->m_pkthdr.rcvif = ifp;
@@ -525,11 +590,24 @@ cgem_recv(struct cgem_softc *sc)
                        }
                }
 
+               /* Queue it up for delivery below. */
+               *m_tl = m;
+               m_tl = &m->m_next;
+       }
+
+       /* Replenish receive buffers. */
+       cgem_fill_rqueue(sc);
+
+       /* Unlock and send up packets. */
+       CGEM_UNLOCK(sc);
+       while (m_hd != NULL) {
+               m = m_hd;
+               m_hd = m_hd->m_next;
+               m->m_next = NULL;
                ifp->if_ipackets++;
-               CGEM_UNLOCK(sc);
                (*ifp->if_input)(ifp, m);
-               CGEM_LOCK(sc);
        }
+       CGEM_LOCK(sc);
 }
 
 /* Find completed transmits and free their mbufs. */
@@ -595,6 +673,8 @@ cgem_clean_tx(struct cgem_softc *sc)
                else
                        sc->txring_tl_ptr++;
                sc->txring_queued--;
+
+               sc->ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
        }
 }
 
@@ -615,16 +695,17 @@ cgem_start_locked(struct ifnet *ifp)
 
        for (;;) {
                /* Check that there is room in the descriptor ring. */
-               if (sc->txring_queued >= CGEM_NUM_TX_DESCS -
-                   TX_MAX_DMA_SEGS - 1) {
+               if (sc->txring_queued >=
+                   CGEM_NUM_TX_DESCS - TX_MAX_DMA_SEGS * 2) {
 
                        /* Try to make room. */
                        cgem_clean_tx(sc);
 
                        /* Still no room? */
-                       if (sc->txring_queued >= CGEM_NUM_TX_DESCS -
-                           TX_MAX_DMA_SEGS - 1) {
+                       if (sc->txring_queued >=
+                           CGEM_NUM_TX_DESCS - TX_MAX_DMA_SEGS * 2) {
                                ifp->if_drv_flags |= IFF_DRV_OACTIVE;
+                               sc->txfull++;
                                break;
                        }
                }
@@ -643,6 +724,7 @@ cgem_start_locked(struct ifnet *ifp)
                        struct mbuf *m2 = m_defrag(m, M_NOWAIT);
 
                        if (m2 == NULL) {
+                               sc->txdefragfails++;
                                m_freem(m);
                                continue;
                        }
@@ -650,10 +732,12 @@ cgem_start_locked(struct ifnet *ifp)
                        err = bus_dmamap_load_mbuf_sg(sc->mbuf_dma_tag,
                                      sc->txring_m_dmamap[sc->txring_hd_ptr],
                                      m, segs, &nsegs, BUS_DMA_NOWAIT);
+                       sc->txdefrags++;
                }
                if (err) {
                        /* Give up. */
                        m_freem(m);
+                       sc->txdmamapfails++;
                        continue;
                }
                sc->txring_m[sc->txring_hd_ptr] = m;
@@ -697,8 +781,10 @@ cgem_start_locked(struct ifnet *ifp)
                /* Kick the transmitter. */
                WR4(sc, CGEM_NET_CTRL, sc->net_ctl_shadow |
                    CGEM_NET_CTRL_START_TX);
-       }
 
+               /* If there is a BPF listener, bounce a copy to to him. */
+               ETHER_BPF_MTAP(ifp, m);
+       }
 }
 
 static void
@@ -712,6 +798,71 @@ cgem_start(struct ifnet *ifp)
 }
 
 static void
+cgem_poll_hw_stats(struct cgem_softc *sc)
+{
+       uint32_t n;
+
+       CGEM_ASSERT_LOCKED(sc);
+
+       sc->stats.tx_bytes += RD4(sc, CGEM_OCTETS_TX_BOT);
+       sc->stats.tx_bytes += (uint64_t)RD4(sc, CGEM_OCTETS_TX_TOP) << 32;
+
+       sc->stats.tx_frames += RD4(sc, CGEM_FRAMES_TX);
+       sc->stats.tx_frames_bcast += RD4(sc, CGEM_BCAST_FRAMES_TX);
+       sc->stats.tx_frames_multi += RD4(sc, CGEM_MULTI_FRAMES_TX);
+       sc->stats.tx_frames_pause += RD4(sc, CGEM_PAUSE_FRAMES_TX);
+       sc->stats.tx_frames_64b += RD4(sc, CGEM_FRAMES_64B_TX);
+       sc->stats.tx_frames_65to127b += RD4(sc, CGEM_FRAMES_65_127B_TX);
+       sc->stats.tx_frames_128to255b += RD4(sc, CGEM_FRAMES_128_255B_TX);
+       sc->stats.tx_frames_256to511b += RD4(sc, CGEM_FRAMES_256_511B_TX);
+       sc->stats.tx_frames_512to1023b += RD4(sc, CGEM_FRAMES_512_1023B_TX);
+       sc->stats.tx_frames_1024to1536b += RD4(sc, CGEM_FRAMES_1024_1518B_TX);
+       sc->stats.tx_under_runs += RD4(sc, CGEM_TX_UNDERRUNS);
+
+       n = RD4(sc, CGEM_SINGLE_COLL_FRAMES);
+       sc->stats.tx_single_collisn += n;
+       sc->ifp->if_collisions += n;
+       n = RD4(sc, CGEM_MULTI_COLL_FRAMES);
+       sc->stats.tx_multi_collisn += n;
+       sc->ifp->if_collisions += n;
+       n = RD4(sc, CGEM_EXCESSIVE_COLL_FRAMES);
+       sc->stats.tx_excsv_collisn += n;
+       sc->ifp->if_collisions += n;
+       n = RD4(sc, CGEM_LATE_COLL);
+       sc->stats.tx_late_collisn += n;
+       sc->ifp->if_collisions += n;
+
+       sc->stats.tx_deferred_frames += RD4(sc, CGEM_DEFERRED_TX_FRAMES);
+       sc->stats.tx_carrier_sense_errs += RD4(sc, CGEM_CARRIER_SENSE_ERRS);
+
+       sc->stats.rx_bytes += RD4(sc, CGEM_OCTETS_RX_BOT);
+       sc->stats.rx_bytes += (uint64_t)RD4(sc, CGEM_OCTETS_RX_TOP) << 32;
+
+       sc->stats.rx_frames += RD4(sc, CGEM_FRAMES_RX);
+       sc->stats.rx_frames_bcast += RD4(sc, CGEM_BCAST_FRAMES_RX);
+       sc->stats.rx_frames_multi += RD4(sc, CGEM_MULTI_FRAMES_RX);
+       sc->stats.rx_frames_pause += RD4(sc, CGEM_PAUSE_FRAMES_RX);
+       sc->stats.rx_frames_64b += RD4(sc, CGEM_FRAMES_64B_RX);
+       sc->stats.rx_frames_65to127b += RD4(sc, CGEM_FRAMES_65_127B_RX);
+       sc->stats.rx_frames_128to255b += RD4(sc, CGEM_FRAMES_128_255B_RX);
+       sc->stats.rx_frames_256to511b += RD4(sc, CGEM_FRAMES_256_511B_RX);
+       sc->stats.rx_frames_512to1023b += RD4(sc, CGEM_FRAMES_512_1023B_RX);
+       sc->stats.rx_frames_1024to1536b += RD4(sc, CGEM_FRAMES_1024_1518B_RX);
+       sc->stats.rx_frames_undersize += RD4(sc, CGEM_UNDERSZ_RX);
+       sc->stats.rx_frames_oversize += RD4(sc, CGEM_OVERSZ_RX);
+       sc->stats.rx_frames_jabber += RD4(sc, CGEM_JABBERS_RX);
+       sc->stats.rx_frames_fcs_errs += RD4(sc, CGEM_FCS_ERRS);
+       sc->stats.rx_frames_length_errs += RD4(sc, CGEM_LENGTH_FIELD_ERRS);
+       sc->stats.rx_symbol_errs += RD4(sc, CGEM_RX_SYMBOL_ERRS);
+       sc->stats.rx_align_errs += RD4(sc, CGEM_ALIGN_ERRS);
+       sc->stats.rx_resource_errs += RD4(sc, CGEM_RX_RESOURCE_ERRS);
+       sc->stats.rx_overrun_errs += RD4(sc, CGEM_RX_OVERRUN_ERRS);
+       sc->stats.rx_ip_hdr_csum_errs += RD4(sc, CGEM_IP_HDR_CKSUM_ERRS);
+       sc->stats.rx_tcp_csum_errs += RD4(sc, CGEM_TCP_CKSUM_ERRS);
+       sc->stats.rx_udp_csum_errs += RD4(sc, CGEM_UDP_CKSUM_ERRS);
+}
+
+static void
 cgem_tick(void *arg)
 {
        struct cgem_softc *sc = (struct cgem_softc *)arg;
@@ -725,6 +876,23 @@ cgem_tick(void *arg)
                mii_tick(mii);
        }
 
+       /* Poll statistics registers. */
+       cgem_poll_hw_stats(sc);
+
+       /* Check for receiver hang. */
+       if (sc->rxhangwar && sc->rx_frames_prev == sc->stats.rx_frames) {
+               /*
+                * Reset receiver logic by toggling RX_EN bit.  1usec
+                * delay is necessary especially when operating at 100mbps
+                * and 10mbps speeds.
+                */
+               WR4(sc, CGEM_NET_CTRL, sc->net_ctl_shadow &
+                   ~CGEM_NET_CTRL_RX_EN);
+               DELAY(1);
+               WR4(sc, CGEM_NET_CTRL, sc->net_ctl_shadow);
+       }
+       sc->rx_frames_prev = sc->stats.rx_frames;
+
        /* Next callout in one second. */
        callout_reset(&sc->tick_ch, hz, cgem_tick, sc);
 }
@@ -743,33 +911,43 @@ cgem_intr(void *arg)
                return;
        }
 
+       /* Read interrupt status and immediately clear the bits. */
        istatus = RD4(sc, CGEM_INTR_STAT);
-       WR4(sc, CGEM_INTR_STAT, istatus &
-           (CGEM_INTR_RX_COMPLETE | CGEM_INTR_TX_USED_READ |
-            CGEM_INTR_RX_OVERRUN | CGEM_INTR_HRESP_NOT_OK));
+       WR4(sc, CGEM_INTR_STAT, istatus);
+
+       /* Packets received. */
+       if ((istatus & CGEM_INTR_RX_COMPLETE) != 0)
+               cgem_recv(sc);
 
-       /* Hresp not ok.  Something very bad with DMA.  Try to clear. */
+       /* Free up any completed transmit buffers. */
+       cgem_clean_tx(sc);
+
+       /* Hresp not ok.  Something is very bad with DMA.  Try to clear. */
        if ((istatus & CGEM_INTR_HRESP_NOT_OK) != 0) {
-               printf("cgem_intr: hresp not okay! rx_status=0x%x\n",
-                      RD4(sc, CGEM_RX_STAT));
+               device_printf(sc->dev, "cgem_intr: hresp not okay! "
+                             "rx_status=0x%x\n", RD4(sc, CGEM_RX_STAT));
                WR4(sc, CGEM_RX_STAT, CGEM_RX_STAT_HRESP_NOT_OK);
        }
 
-       /* Transmitter has idled.  Free up any spent transmit buffers. */
-       if ((istatus & CGEM_INTR_TX_USED_READ) != 0)
-               cgem_clean_tx(sc);
+       /* Receiver overrun. */
+       if ((istatus & CGEM_INTR_RX_OVERRUN) != 0) {
+               /* Clear status bit. */
+               WR4(sc, CGEM_RX_STAT, CGEM_RX_STAT_OVERRUN);
+               sc->rxoverruns++;
+       }
 
-       /* Packets received or overflow. */
-       if ((istatus & (CGEM_INTR_RX_COMPLETE | CGEM_INTR_RX_OVERRUN)) != 0) {
-               cgem_recv(sc);
+       /* Receiver ran out of bufs. */
+       if ((istatus & CGEM_INTR_RX_USED_READ) != 0) {
+               WR4(sc, CGEM_NET_CTRL, sc->net_ctl_shadow |
+                   CGEM_NET_CTRL_FLUSH_DPRAM_PKT);
                cgem_fill_rqueue(sc);
-               if ((istatus & CGEM_INTR_RX_OVERRUN) != 0) {
-                       /* Clear rx status register. */
-                       sc->rxoverruns++;
-                       WR4(sc, CGEM_RX_STAT, CGEM_RX_STAT_ALL);
-               }
+               sc->rxnobufs++;
        }
 
+       /* Restart transmitter if needed. */
+       if (!IFQ_DRV_IS_EMPTY(&sc->ifp->if_snd))
+               cgem_start_locked(sc->ifp);
+
        CGEM_UNLOCK(sc);
 }
 
@@ -806,6 +984,7 @@ cgem_config(struct cgem_softc *sc)
 {
        uint32_t net_cfg;
        uint32_t dma_cfg;
+       u_char *eaddr = IF_LLADDR(sc->ifp);
 
        CGEM_ASSERT_LOCKED(sc);
 
@@ -815,6 +994,7 @@ cgem_config(struct cgem_softc *sc)
                CGEM_NET_CFG_FCS_REMOVE |
                CGEM_NET_CFG_RX_BUF_OFFSET(ETHER_ALIGN) |
                CGEM_NET_CFG_GIGE_EN |
+               CGEM_NET_CFG_1536RXEN |
                CGEM_NET_CFG_FULL_DUPLEX |
                CGEM_NET_CFG_SPEED100;
 
@@ -828,7 +1008,8 @@ cgem_config(struct cgem_softc *sc)
        dma_cfg = CGEM_DMA_CFG_RX_BUF_SIZE(MCLBYTES) |
                CGEM_DMA_CFG_RX_PKTBUF_MEMSZ_SEL_8K |
                CGEM_DMA_CFG_TX_PKTBUF_MEMSZ_SEL |
-               CGEM_DMA_CFG_AHB_FIXED_BURST_LEN_16;
+               CGEM_DMA_CFG_AHB_FIXED_BURST_LEN_16 |
+               CGEM_DMA_CFG_DISC_WHEN_NO_AHB;
 
        /* Enable transmit checksum offloading? */
        if ((sc->ifp->if_capenable & IFCAP_TXCSUM) != 0)
@@ -844,10 +1025,16 @@ cgem_config(struct cgem_softc *sc)
        sc->net_ctl_shadow |= (CGEM_NET_CTRL_TX_EN | CGEM_NET_CTRL_RX_EN);
        WR4(sc, CGEM_NET_CTRL, sc->net_ctl_shadow);
 
+       /* Set receive address in case it changed. */
+       WR4(sc, CGEM_SPEC_ADDR_LOW(0), (eaddr[3] << 24) |
+           (eaddr[2] << 16) | (eaddr[1] << 8) | eaddr[0]);
+       WR4(sc, CGEM_SPEC_ADDR_HI(0), (eaddr[5] << 8) | eaddr[4]);
+
        /* Set up interrupts. */
        WR4(sc, CGEM_INTR_EN,
-           CGEM_INTR_RX_COMPLETE | CGEM_INTR_TX_USED_READ |
-           CGEM_INTR_RX_OVERRUN | CGEM_INTR_HRESP_NOT_OK);
+           CGEM_INTR_RX_COMPLETE | CGEM_INTR_RX_OVERRUN |
+           CGEM_INTR_TX_USED_READ | CGEM_INTR_RX_USED_READ |
+           CGEM_INTR_HRESP_NOT_OK);
 }
 
 /* Turn on interface and load up receive ring with buffers. */
@@ -868,8 +1055,7 @@ cgem_init_locked(struct cgem_softc *sc)
        sc->ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
 
        mii = device_get_softc(sc->miibus);
-       mii_pollstat(mii);
-       cgem_start_locked(sc->ifp);
+       mii_mediachg(mii);
 
        callout_reset(&sc->tick_ch, hz, cgem_tick, sc);
 }
@@ -932,6 +1118,9 @@ cgem_stop(struct cgem_softc *sc)
        sc->rxring_hd_ptr = 0;
        sc->rxring_tl_ptr = 0;
        sc->rxring_queued = 0;
+
+       /* Force next statchg or linkchg to program net config register. */
+       sc->mii_media_active = 0;
 }
 
 
@@ -1021,6 +1210,11 @@ cgem_ioctl(struct ifnet *ifp, u_long cmd
                                     ~CGEM_NET_CFG_RX_CHKSUM_OFFLD_EN);
                        }
                }
+               if ((ifp->if_capenable & (IFCAP_RXCSUM | IFCAP_TXCSUM)) == 
+                   (IFCAP_RXCSUM | IFCAP_TXCSUM))
+                       ifp->if_capenable |= IFCAP_VLAN_HWCSUM;
+               else
+                       ifp->if_capenable &= ~IFCAP_VLAN_HWCSUM;
 
                CGEM_UNLOCK(sc);
                break;
@@ -1038,6 +1232,7 @@ static void
 cgem_child_detached(device_t dev, device_t child)
 {
        struct cgem_softc *sc = device_get_softc(dev);
+
        if (child == sc->miibus)
                sc->miibus = NULL;
 }
@@ -1047,12 +1242,18 @@ cgem_ifmedia_upd(struct ifnet *ifp)
 {
        struct cgem_softc *sc = (struct cgem_softc *) ifp->if_softc;
        struct mii_data *mii;
-       int error;
+       struct mii_softc *miisc;
+       int error = 0;
 
        mii = device_get_softc(sc->miibus);
        CGEM_LOCK(sc);
-       error = mii_mediachg(mii);
+       if ((ifp->if_flags & IFF_UP) != 0) {
+               LIST_FOREACH(miisc, &mii->mii_phys, mii_list)
+                       PHY_RESET(miisc);
+               error = mii_mediachg(mii);
+       }
        CGEM_UNLOCK(sc);
+
        return (error);
 }
 
@@ -1094,6 +1295,13 @@ cgem_miibus_readreg(device_t dev, int ph
 
        val = RD4(sc, CGEM_PHY_MAINT) & CGEM_PHY_MAINT_DATA_MASK;
 
+       if (reg == MII_EXTSR)
+               /*
+                * MAC does not support half-duplex at gig speeds.
+                * Let mii(4) exclude the capability.
+                */
+               val &= ~(EXTSR_1000XHDX | EXTSR_1000THDX);
+
        return (val);
 }
 
@@ -1123,6 +1331,34 @@ cgem_miibus_writereg(device_t dev, int p
        return (0);
 }
 
+static void
+cgem_miibus_statchg(device_t dev)
+{
+       struct cgem_softc *sc  = device_get_softc(dev);
+       struct mii_data *mii = device_get_softc(sc->miibus);
+
+       CGEM_ASSERT_LOCKED(sc);
+
+       if ((mii->mii_media_status & (IFM_ACTIVE | IFM_AVALID)) ==
+           (IFM_ACTIVE | IFM_AVALID) &&
+           sc->mii_media_active != mii->mii_media_active)
+               cgem_mediachange(sc, mii);
+}
+
+static void
+cgem_miibus_linkchg(device_t dev)
+{
+       struct cgem_softc *sc  = device_get_softc(dev);
+       struct mii_data *mii = device_get_softc(sc->miibus);
+
+       CGEM_ASSERT_LOCKED(sc);
+
+       if ((mii->mii_media_status & (IFM_ACTIVE | IFM_AVALID)) ==
+           (IFM_ACTIVE | IFM_AVALID) &&
+           sc->mii_media_active != mii->mii_media_active)
+               cgem_mediachange(sc, mii);
+}
+
 /*
  * Overridable weak symbol cgem_set_ref_clk().  This allows platforms to
  * provide a function to set the cgem's reference clock.
@@ -1135,49 +1371,226 @@ cgem_default_set_ref_clk(int unit, int f
 }
 __weak_reference(cgem_default_set_ref_clk, cgem_set_ref_clk);
 
+/* Call to set reference clock and network config bits according to media. */
 static void
-cgem_miibus_statchg(device_t dev)
+cgem_mediachange(struct cgem_softc *sc,        struct mii_data *mii)
 {
-       struct cgem_softc *sc;
-       struct mii_data *mii;
        uint32_t net_cfg;
        int ref_clk_freq;
 
-       sc  = device_get_softc(dev);
-
-       mii = device_get_softc(sc->miibus);
+       CGEM_ASSERT_LOCKED(sc);
 
-       if ((mii->mii_media_status & IFM_AVALID) != 0) {
-               /* Update hardware to reflect phy status. */
-               net_cfg = RD4(sc, CGEM_NET_CFG);
-               net_cfg &= ~(CGEM_NET_CFG_SPEED100 | CGEM_NET_CFG_GIGE_EN |
-                            CGEM_NET_CFG_FULL_DUPLEX);
-
-               switch (IFM_SUBTYPE(mii->mii_media_active)) {
-               case IFM_1000_T:
-                       net_cfg |= (CGEM_NET_CFG_SPEED100 |
-                                   CGEM_NET_CFG_GIGE_EN);
-                       ref_clk_freq = 125000000;
-                       break;
-               case IFM_100_TX:
-                       net_cfg |= CGEM_NET_CFG_SPEED100;
-                       ref_clk_freq = 25000000;
-                       break;
-               default:
-                       ref_clk_freq = 2500000;
-               }
+       /* Update hardware to reflect media. */
+       net_cfg = RD4(sc, CGEM_NET_CFG);
+       net_cfg &= ~(CGEM_NET_CFG_SPEED100 | CGEM_NET_CFG_GIGE_EN |
+                    CGEM_NET_CFG_FULL_DUPLEX);
 
-               if ((mii->mii_media_active & IFM_FDX) != 0)
-                       net_cfg |= CGEM_NET_CFG_FULL_DUPLEX;
-               WR4(sc, CGEM_NET_CFG, net_cfg);
-
-               /* Set the reference clock if necessary. */
-               if (cgem_set_ref_clk(sc->ref_clk_num, ref_clk_freq))
-                       device_printf(dev, "could not set ref clk%d to %d.\n",
-                                     sc->ref_clk_num, ref_clk_freq);
+       switch (IFM_SUBTYPE(mii->mii_media_active)) {
+       case IFM_1000_T:
+               net_cfg |= (CGEM_NET_CFG_SPEED100 |
+                           CGEM_NET_CFG_GIGE_EN);
+               ref_clk_freq = 125000000;
+               break;
+       case IFM_100_TX:
+               net_cfg |= CGEM_NET_CFG_SPEED100;
+               ref_clk_freq = 25000000;
+               break;
+       default:
+               ref_clk_freq = 2500000;
        }
+
+       if ((mii->mii_media_active & IFM_FDX) != 0)
+               net_cfg |= CGEM_NET_CFG_FULL_DUPLEX;
+
+       WR4(sc, CGEM_NET_CFG, net_cfg);
+
+       /* Set the reference clock if necessary. */
+       if (cgem_set_ref_clk(sc->ref_clk_num, ref_clk_freq))
+               device_printf(sc->dev, "cgem_mediachange: "
+                             "could not set ref clk%d to %d.\n",
+                             sc->ref_clk_num, ref_clk_freq);
+
+       sc->mii_media_active = mii->mii_media_active;
 }
 
+static void
+cgem_add_sysctls(device_t dev)
+{
+       struct cgem_softc *sc = device_get_softc(dev);
+       struct sysctl_ctx_list *ctx;
+       struct sysctl_oid_list *child;
+       struct sysctl_oid *tree;
+
+       ctx = device_get_sysctl_ctx(dev);
+       child = SYSCTL_CHILDREN(device_get_sysctl_tree(dev));
+
+       SYSCTL_ADD_INT(ctx, child, OID_AUTO, "rxbufs", CTLFLAG_RW,
+                      &sc->rxbufs, 0,
+                      "Number receive buffers to provide");
+
+       SYSCTL_ADD_INT(ctx, child, OID_AUTO, "rxhangwar", CTLFLAG_RW,
+                      &sc->rxhangwar, 0,
+                      "Enable receive hang work-around");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "_rxoverruns", CTLFLAG_RD,
+                       &sc->rxoverruns, 0,
+                       "Receive overrun events");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "_rxnobufs", CTLFLAG_RD,
+                       &sc->rxnobufs, 0,
+                       "Receive buf queue empty events");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "_rxdmamapfails", CTLFLAG_RD,
+                       &sc->rxdmamapfails, 0,
+                       "Receive DMA map failures");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "_txfull", CTLFLAG_RD,
+                       &sc->txfull, 0,
+                       "Transmit ring full events");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "_txdmamapfails", CTLFLAG_RD,
+                       &sc->txdmamapfails, 0,
+                       "Transmit DMA map failures");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "_txdefrags", CTLFLAG_RD,
+                       &sc->txdefrags, 0,
+                       "Transmit m_defrag() calls");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "_txdefragfails", CTLFLAG_RD,
+                       &sc->txdefragfails, 0,
+                       "Transmit m_defrag() failures");
+
+       tree = SYSCTL_ADD_NODE(ctx, child, OID_AUTO, "stats", CTLFLAG_RD,
+                              NULL, "GEM statistics");
+       child = SYSCTL_CHILDREN(tree);
+
+       SYSCTL_ADD_UQUAD(ctx, child, OID_AUTO, "tx_bytes", CTLFLAG_RD,
+                        &sc->stats.tx_bytes, "Total bytes transmitted");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames", CTLFLAG_RD,
+                       &sc->stats.tx_frames, 0, "Total frames transmitted");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_bcast", CTLFLAG_RD,
+                       &sc->stats.tx_frames_bcast, 0,
+                       "Number broadcast frames transmitted");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_multi", CTLFLAG_RD,
+                       &sc->stats.tx_frames_multi, 0,
+                       "Number multicast frames transmitted");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_pause",
+                       CTLFLAG_RD, &sc->stats.tx_frames_pause, 0,
+                       "Number pause frames transmitted");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_64b", CTLFLAG_RD,
+                       &sc->stats.tx_frames_64b, 0,
+                       "Number frames transmitted of size 64 bytes or less");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_65to127b", CTLFLAG_RD,
+                       &sc->stats.tx_frames_65to127b, 0,
+                       "Number frames transmitted of size 65-127 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_128to255b",
+                       CTLFLAG_RD, &sc->stats.tx_frames_128to255b, 0,
+                       "Number frames transmitted of size 128-255 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_256to511b",
+                       CTLFLAG_RD, &sc->stats.tx_frames_256to511b, 0,
+                       "Number frames transmitted of size 256-511 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_512to1023b",
+                       CTLFLAG_RD, &sc->stats.tx_frames_512to1023b, 0,
+                       "Number frames transmitted of size 512-1023 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_frames_1024to1536b",
+                       CTLFLAG_RD, &sc->stats.tx_frames_1024to1536b, 0,
+                       "Number frames transmitted of size 1024-1536 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_under_runs",
+                       CTLFLAG_RD, &sc->stats.tx_under_runs, 0,
+                       "Number transmit under-run events");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_single_collisn",
+                       CTLFLAG_RD, &sc->stats.tx_single_collisn, 0,
+                       "Number single-collision transmit frames");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_multi_collisn",
+                       CTLFLAG_RD, &sc->stats.tx_multi_collisn, 0,
+                       "Number multi-collision transmit frames");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_excsv_collisn",
+                       CTLFLAG_RD, &sc->stats.tx_excsv_collisn, 0,
+                       "Number excessive collision transmit frames");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_late_collisn",
+                       CTLFLAG_RD, &sc->stats.tx_late_collisn, 0,
+                       "Number late-collision transmit frames");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_deferred_frames",
+                       CTLFLAG_RD, &sc->stats.tx_deferred_frames, 0,
+                       "Number deferred transmit frames");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tx_carrier_sense_errs",
+                       CTLFLAG_RD, &sc->stats.tx_carrier_sense_errs, 0,
+                       "Number carrier sense errors on transmit");
+
+       SYSCTL_ADD_UQUAD(ctx, child, OID_AUTO, "rx_bytes", CTLFLAG_RD,
+                        &sc->stats.rx_bytes, "Total bytes received");
+
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames", CTLFLAG_RD,
+                       &sc->stats.rx_frames, 0, "Total frames received");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_bcast",
+                       CTLFLAG_RD, &sc->stats.rx_frames_bcast, 0,
+                       "Number broadcast frames received");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_multi",
+                       CTLFLAG_RD, &sc->stats.rx_frames_multi, 0,
+                       "Number multicast frames received");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_pause",
+                       CTLFLAG_RD, &sc->stats.rx_frames_pause, 0,
+                       "Number pause frames received");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_64b",
+                       CTLFLAG_RD, &sc->stats.rx_frames_64b, 0,
+                       "Number frames received of size 64 bytes or less");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_65to127b",
+                       CTLFLAG_RD, &sc->stats.rx_frames_65to127b, 0,
+                       "Number frames received of size 65-127 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_128to255b",
+                       CTLFLAG_RD, &sc->stats.rx_frames_128to255b, 0,
+                       "Number frames received of size 128-255 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_256to511b",
+                       CTLFLAG_RD, &sc->stats.rx_frames_256to511b, 0,
+                       "Number frames received of size 256-511 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_512to1023b",
+                       CTLFLAG_RD, &sc->stats.rx_frames_512to1023b, 0,
+                       "Number frames received of size 512-1023 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_1024to1536b",
+                       CTLFLAG_RD, &sc->stats.rx_frames_1024to1536b, 0,
+                       "Number frames received of size 1024-1536 bytes");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_undersize",
+                       CTLFLAG_RD, &sc->stats.rx_frames_undersize, 0,
+                       "Number undersize frames received");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_oversize",
+                       CTLFLAG_RD, &sc->stats.rx_frames_oversize, 0,
+                       "Number oversize frames received");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_jabber",
+                       CTLFLAG_RD, &sc->stats.rx_frames_jabber, 0,
+                       "Number jabber frames received");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_fcs_errs",
+                       CTLFLAG_RD, &sc->stats.rx_frames_fcs_errs, 0,
+                       "Number frames received with FCS errors");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_length_errs",
+                       CTLFLAG_RD, &sc->stats.rx_frames_length_errs, 0,
+                       "Number frames received with length errors");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_symbol_errs",
+                       CTLFLAG_RD, &sc->stats.rx_symbol_errs, 0,
+                       "Number receive symbol errors");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_align_errs",
+                       CTLFLAG_RD, &sc->stats.rx_align_errs, 0,
+                       "Number receive alignment errors");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_resource_errs",
+                       CTLFLAG_RD, &sc->stats.rx_resource_errs, 0,
+                       "Number frames received when no rx buffer available");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_overrun_errs",
+                       CTLFLAG_RD, &sc->stats.rx_overrun_errs, 0,
+                       "Number frames received but not copied due to "
+                       "receive overrun");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_ip_hdr_csum_errs",
+                       CTLFLAG_RD, &sc->stats.rx_ip_hdr_csum_errs, 0,
+                       "Number frames received with IP header checksum "
+                       "errors");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_tcp_csum_errs",
+                       CTLFLAG_RD, &sc->stats.rx_tcp_csum_errs, 0,
+                       "Number frames received with TCP checksum errors");
+       SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "rx_frames_udp_csum_errs",
+                       CTLFLAG_RD, &sc->stats.rx_udp_csum_errs, 0,
+                       "Number frames received with UDP checksum errors");
+}
+
+
 static int
 cgem_probe(device_t dev)
 {
@@ -1227,24 +1640,43 @@ cgem_attach(device_t dev)
                return (ENOMEM);
        }
 
+       /* Set up ifnet structure. */
        ifp = sc->ifp = if_alloc(IFT_ETHER);
        if (ifp == NULL) {
                device_printf(dev, "could not allocate ifnet structure\n");
                cgem_detach(dev);
                return (ENOMEM);
        }
+       ifp->if_softc = sc;
+       if_initname(ifp, IF_CGEM_NAME, device_get_unit(dev));
+       ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;
+       ifp->if_start = cgem_start;
+       ifp->if_ioctl = cgem_ioctl;
+       ifp->if_init = cgem_init;
+       ifp->if_capabilities |= IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6 |
+               IFCAP_VLAN_MTU | IFCAP_VLAN_HWCSUM;
+       /* Disable hardware checksumming by default. */
+       ifp->if_hwassist = 0;
+       ifp->if_capenable = ifp->if_capabilities &
+               ~(IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6 | IFCAP_VLAN_HWCSUM);
+       ifp->if_snd.ifq_drv_maxlen = CGEM_NUM_TX_DESCS;
+       IFQ_SET_MAXLEN(&ifp->if_snd, ifp->if_snd.ifq_drv_maxlen);
+       IFQ_SET_READY(&ifp->if_snd);
 
-       CGEM_LOCK(sc);
+       sc->if_old_flags = ifp->if_flags;
+       sc->rxbufs = DEFAULT_NUM_RX_BUFS;
+       sc->rxhangwar = 1;
 
        /* Reset hardware. */
+       CGEM_LOCK(sc);
        cgem_reset(sc);
+       CGEM_UNLOCK(sc);
 
        /* Attach phy to mii bus. */
        err = mii_attach(dev, &sc->miibus, ifp,
                         cgem_ifmedia_upd, cgem_ifmedia_sts,
                         BMSR_DEFCAPMASK, MII_PHY_ANY, MII_OFFSET_ANY, 0);
        if (err) {
-               CGEM_UNLOCK(sc);
                device_printf(dev, "attaching PHYs failed\n");
                cgem_detach(dev);
                return (err);
@@ -1253,7 +1685,6 @@ cgem_attach(device_t dev)
        /* Set up TX and RX descriptor area. */
        err = cgem_setup_descs(sc);
        if (err) {
-               CGEM_UNLOCK(sc);
                device_printf(dev, "could not set up dma mem for descs.\n");
                cgem_detach(dev);
                return (ENOMEM);
@@ -1265,50 +1696,18 @@ cgem_attach(device_t dev)
        /* Start ticks. */
        callout_init_mtx(&sc->tick_ch, &sc->sc_mtx, 0);
 
-       /* Set up ifnet structure. */
-       ifp->if_softc = sc;
-       if_initname(ifp, IF_CGEM_NAME, device_get_unit(dev));
-       ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;
-       ifp->if_start = cgem_start;
-       ifp->if_ioctl = cgem_ioctl;
-       ifp->if_init = cgem_init;
-       ifp->if_capabilities |= IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6;
-       /* XXX: disable hw checksumming for now. */
-       ifp->if_hwassist = 0;
-       ifp->if_capenable = ifp->if_capabilities &
-               ~(IFCAP_HWCSUM | IFCAP_HWCSUM_IPV6);
-       IFQ_SET_MAXLEN(&ifp->if_snd, IFQ_MAXLEN);
-       ifp->if_snd.ifq_drv_maxlen = IFQ_MAXLEN;
-       IFQ_SET_READY(&ifp->if_snd);
-
-       sc->if_old_flags = ifp->if_flags;
-       sc->rxbufs = DEFAULT_NUM_RX_BUFS;
-
        ether_ifattach(ifp, eaddr);
 
        err = bus_setup_intr(dev, sc->irq_res, INTR_TYPE_NET | INTR_MPSAFE |
                             INTR_EXCL, NULL, cgem_intr, sc, &sc->intrhand);
        if (err) {
-               CGEM_UNLOCK(sc);
                device_printf(dev, "could not set interrupt handler.\n");
                ether_ifdetach(ifp);
                cgem_detach(dev);
                return (err);
        }
 
-       SYSCTL_ADD_INT(device_get_sysctl_ctx(dev),
-                      SYSCTL_CHILDREN(device_get_sysctl_tree(dev)),
-                      OID_AUTO, "rxbufs", CTLFLAG_RW,
-                      &sc->rxbufs, 0,
-                      "Number receive buffers to provide");
-
-       SYSCTL_ADD_INT(device_get_sysctl_ctx(dev),
-                      SYSCTL_CHILDREN(device_get_sysctl_tree(dev)),
-                      OID_AUTO, "_rxoverruns", CTLFLAG_RD,
-                      &sc->rxoverruns, 0,
-                      "Receive ring overrun events");
-
-       CGEM_UNLOCK(sc);
+       cgem_add_sysctls(dev);
 
        return (0);
 }
@@ -1336,7 +1735,7 @@ cgem_detach(device_t dev)
                sc->miibus = NULL;
        }
 
-       /* Release resrouces. */
+       /* Release resources. */
        if (sc->mem_res != NULL) {
                bus_release_resource(dev, SYS_RES_MEMORY,
                                     rman_get_rid(sc->mem_res), sc->mem_res);
@@ -1410,6 +1809,7 @@ static device_method_t cgem_methods[] = 
        DEVMETHOD(miibus_readreg,       cgem_miibus_readreg),
        DEVMETHOD(miibus_writereg,      cgem_miibus_writereg),
        DEVMETHOD(miibus_statchg,       cgem_miibus_statchg),
+       DEVMETHOD(miibus_linkchg,       cgem_miibus_linkchg),
 
        DEVMETHOD_END
 };

Modified: head/sys/dev/cadence/if_cgem_hw.h
==============================================================================
--- head/sys/dev/cadence/if_cgem_hw.h   Wed Sep  3 17:32:17 2014        
(r271045)
+++ head/sys/dev/cadence/if_cgem_hw.h   Wed Sep  3 17:51:03 2014        
(r271046)
@@ -90,6 +90,7 @@
 #define   CGEM_NET_CFG_PCS_SEL                 (1<<11)
 #define   CGEM_NET_CFG_GIGE_EN                 (1<<10)
 #define   CGEM_NET_CFG_EXT_ADDR_MATCH_EN       (1<<9)
+#define   CGEM_NET_CFG_1536RXEN                        (1<<8)
 #define   CGEM_NET_CFG_UNI_HASH_EN             (1<<7)
 #define   CGEM_NET_CFG_MULTI_HASH_EN           (1<<6)
 #define   CGEM_NET_CFG_NO_BCAST                        (1<<5)
@@ -260,8 +261,8 @@
 #define CGEM_FRAMES_256_511B_RX                0x174   /* 256-511 Byte Frames 
Rx'd */
 #define CGEM_FRAMES_512_1023B_RX       0x178   /* 512-1023 Byte Frames Rx'd */
 #define CGEM_FRAMES_1024_1518B_RX      0x17C   /* 1024-1518 Byte Frames Rx'd*/
-#define CGEM_UNDERSZ_RX                        0x180   /* Undersize Frames 
Rx'd */
-#define CGEM_OVERSZ_RX                 0x184   /* Oversize Frames Rx'd */
+#define CGEM_UNDERSZ_RX                        0x184   /* Undersize Frames 
Rx'd */
+#define CGEM_OVERSZ_RX                 0x188   /* Oversize Frames Rx'd */

*** DIFF OUTPUT TRUNCATED AT 1000 LINES ***
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to