I approve.
Отправлено с Samsung Mobile -------- Исходное сообщение -------- От: Alexander Scherbatiy <[email protected]> Дата: 16.08.2013 15:39 (GMT+04:00) Кому: sergey malenkov <[email protected]>,[email protected],Sergey Bylokhov <[email protected]> Тема: Re: [8] Review request for 7083457 Incomplete specification for javax/swing/text/DefaultCaret.html#setVisible(boolean) Could you review the same fix with the added test: http://cr.openjdk.java.net/~alexsch/7083457/webrev.01/ Thanks, Alexandr. On 8/15/2013 6:47 PM, sergey malenkov wrote: > Hi Alexander, > > The fix is good, but there is no test in webrev. > > Thanks, > SAM > > On 15.08.2013 17:57, Alexander Scherbatiy wrote: >> >> Hello, >> >> Could you review the fix: >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7083457 >> webrev: http://cr.openjdk.java.net/~alexsch/7083457/webrev.00 >> >> According to the javadoc the DefaultCaret.setVisible(boolean e) >> should always update the getActive() state. >> >> Thanks, >> Alexandr. >> >
