On St 11. prosinec 2013, 03:02:48 CET, Lennart Poettering wrote:
On Fri, 08.11.13 07:32, Michal Sekletar (msekl...@redhat.com) wrote:
On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote:
On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote:
Type x in tmpfiles configuration accepts shell style globs instead of normal
paths. If user uses normal path he might expect that the path will be left
untouched. However this is not the case for directories and content of the
directory will be cleaned according to the Age parameter, we should rather skip
the path entirely in such case.
Hi Lennart,
Not sure I follow. dir_cleanup() already skips all items listed in the
glob hashmap anyway, no? What does your patch add on top of that?
In dir_cleanup() we skip if there is an item configured for the path or it
matches the glob, however we are doing it on the subpaths of currently processed
directory. This won't work in the case mentioned in the commit message. If user
wants to exclude path from cleanup entirely he has to use x /path/*, this way
all subpaths match the glob. In case of x /path/ no subpath matches such glob
and
we remove them, hence checking explicitly beforehand.
Hope that makes some sense.
Nope. Still not following. Can you give an explicit example of a
complete but minimal tmpfiles snippet that currently doesn't behave
correctly and that does with your patch? Maybe I grok it then!
Thanks,
Lennart
We discussed and tested it here with Michal and Lukas again and came to
conclusion the behavior is correct as is.
Thanks,
Vaclav
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
