On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote: > On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek > <zbys...@in.waw.pl> wrote: > >> + if (client->fd > 0) > >> + safe_close(client->fd); > >> + client->fd = -1; > > client->fd = safe_close(client->fd); > > > > That's what safe_close is for :) > > And shouldn't the check be for client->fd >= 0? Zero is a valid file > descriptor. Yeah... but note that safe_close already has the fd >= 0 check, so the replacement line replaces the if too.
Zbyszek _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel