David Herrmann <dh.herrm...@gmail.com> writes: > Hi > > On Mon, Sep 15, 2014 at 10:00 AM, Jan Synacek <jsyna...@redhat.com> wrote: >> David Herrmann <dh.herrm...@gmail.com> writes: >>> Nevertheless, the documentation should clearly state which input is >>> expected and the current code is definitely wrong as it only performs >>> one way conversions. >> >> Could you please point me to the right documentation that I can update? >> My guess would be sysctl.d(5), since systemd-sysctl(8) refers to it. >> Also, should I make it a separate patch? > > I was referring to the --help text of the binary. There is no man-page > for it, so no need to update any of them. > > Feel free to put me on CC on v2 and I'll apply the patch. > > Thanks a lot! > David
After tinkering with it for a while, I think that my original patch is correct. The prefix is a path prefix that is matched against actual paths, not variable names. That means that the prefix always has to start with a slash, otherwise nothing matches, which also means that normalizing would have no effect. And I think that the docstring doesn't need an update either. It says "Only apply rules that apply to *paths with the specified prefix*" (my emphasis added). -- Jan Synacek Software Engineer, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel