Ian Kent wrote on 29/07/2020 01:57: > On Tue, 2020-07-28 at 16:13 +0200, Lennart Poettering wrote: >> On Mo, 27.07.20 12:57, Ian Kent (ik...@redhat.com) wrote: >> >>> Further to my post about using the new mount table notifications in >>> systemd I'd like to start by posting a few patches for discussion >>> to >>> hopefully get a better understanding of some aspects of how systemd >>> mount unit state handling works, and also to get guidance on >>> systemd >>> coding style, and generally how I should be doing things in systemd >>> as well as how best to debug problems. >> >> Thank you for working on this! >> >> We do reviews exclusively on github these days, could you please >> submit this as PR on github? > > Thanks Lennart, will do. > > Although I was hoping for some generic discussion on this to set > me going in the right direction. > > If that's not ok then I'll submit a PR when I think it's ready.
Although I'm not as familiar with the development process as I used to be, you can file it now, even in it's current state for that discussion process. It can be an RFC Pull request. Just means the discussion can all take place in Github and can go through various iterations there. So, in short, don't worry about it being fully "ready" before pushing and doing a pull requests. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel
