On 08/27/2014 12:47 PM, Edward Betts wrote:
I'd like to annotate these 70k objects in OSM with a Wikidata tag automatically.
I like the sound of this. Personally, I think it adds value, and having looked at the code your matching criteria sound good.
There are a couple of things it would make me happy to see before you go through with this:
1: Elsewhere in this thread it was mentioned that there are 22000 wikidata ids in OSM currently. Are there any objects which currently have a wikidata id that your code would assign a different id to? Similarly, are there any instances where your code would assign a wikidata id to something and a different object in OSM already has that wikidata id?
I assume your plan is to not modify these, but I'm more concerned with seeing how well your code matches what's already in OSM as a verification tool.
2: You mention elsewhere in this thread that the maximum distance difference between the wikidata location and the osm object is 400 meters. How was this number arrived at? Could you make a list of matches including and sorted by the distance difference for people to look at? I think it's worth it for interested people to be able to independently verify at what distance the accuracy declines and what a good cutoff is.
It might be good to also include in that list what type of feature something is. If you're comparing using centroids, more leniency might be in order for, e.g., a large lake than a small building.
To be honest, I still support this import even without these verification tools, but it would make me very happy to see them.
--Andrew _______________________________________________ talk mailing list talk@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk
