As of tboot 1.10.4, lcp2_mlehash has stopped working due to 643:8635a40eab19 Touch ups for GCC12:

lcp2_mlehash --create --verbose /boot/tboot.gz
cmdline opt: mlefile:/boot/tboot.gz
[read_mle_file]
checking whether the file exists or not ... : existed!
trying to uncompress the file ... : succeeded!
creating a temporary file to uncompress ... : succeeded!
opening the decompressed file ... : succeeded!
testing decompression is ... : succeeded!
reading the decompressed file ... : succeeded!
[is_elf_image]
checking whether image is an elf image ... : failed! - Pointer is zero.

It looks like fix was designed to fix a use-after-free warning (which, due to -Werror is fatal), but the original code looks correct. I believe the gcc warning is bogus.

On a side note, could the -Werror flag be removed by default? Its useful for development but not in release versions: See https://flameeyes.blog/2009/02/25/future-proof-your-code-dont-use-werror/?utm_source=blogdoteu&utm_medium=referral&utm_campaign=permanent


_______________________________________________
tboot-devel mailing list
tboot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tboot-devel

Reply via email to