On Wed, Apr 10, 2002 at 10:49:57PM +0200, Jørgen Thomsen wrote:
> I find it strange that this optiion has not been added a long time ago:
> printing the packets in ASCII only close to the layout of the actual text
> (e.g. web pages)

It might be nice to have it do so only for protocols where the packets
*are* ASCII; how well does this work for captures that are a mix of,
say, HTTP and other binary protocols?  (For example, a capture with a
lot of HTTP and a lot of NFS or CIFS?)

> On my Redhat Linux 7.2 i586 system I am a little concerned about these
> compilation warnings:
>  
> gcc -O2 -DHAVE_CONFIG_H -I. -I../libpcap  -I./missing -I/usr/include -c ./print-nfs.c
> ./print-nfs.c: In function `nfs_printfh':
> ./print-nfs.c:761: warning: passing arg 6 of `Parse_fh' from incompatible pointer 
>type
> gcc -O2 -DHAVE_CONFIG_H -I. -I../libpcap  -I./missing -I/usr/include -c ./print-ntp.c
> gcc -O2 -DHAVE_CONFIG_H -I. -I../libpcap  -I./missing -I/usr/include -c 
>./print-radius.c
> ./print-radius.c: In function `print_attr_time':
> ./print-radius.c:664: warning: passing arg 2 of `strlcpy' makes pointer from integer 
>without a cast

I've checked in a change to make it include <time.h> to declare
"ctime()".

> gcc -O2 -DHAVE_CONFIG_H -I. -I../libpcap  -I./missing -I/usr/include -c ./print-raw.c
> cc -O2 -DHAVE_CONFIG_H -I. -I../libpcap  -I./missing -I/usr/include -c ./setsignal.c
> ./setsignal.c: In function `setsignal':
> ./setsignal.c:72: warning: return makes pointer from integer without a cast

Can anybody think of a good reason *why* we "prefer sigset() to
sigaction()", as the AC_LBL_TYPE_SIGNAL macro does? If we don't do that,
and just use "sigaction()" (the standard POSIX call) if present, that
warning will, I think, go away.
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe

Reply via email to