> X-Envelope-From: s...@stsp.name > Date: Fri, 22 Apr 2011 15:54:32 +0200 > From: Stefan Sperling <s...@openbsd.org> > Cc: tech@openbsd.org > Mail-Followup-To: Mark Kettenis <mark.kette...@xs4all.nl>, tech@openbsd.org > X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 > List-Owner: <mailto:owner-t...@openbsd.org> > X-Loop: tech@openbsd.org > Sender: owner-t...@openbsd.org > X-XS4ALL-DNSBL-Checked: mxdrop225.xs4all.nl checked 192.43.244.163 against > DNS blacklists > X-CNFS-Analysis: v=1.1 cv=0zc6fmG9YcuPB4Yp6G+9JUp7sX0X0uIJmZE+jPYAbEE= c=1 > sm=0 a=wom5GMh1gUkA:10 a=ICHTHJBzbYQA:10 a=kj9zAlcOel0A:10 > a=A3duGc4wJ8K8BtNzzvyz4A==:17 a=wpzRm42BFkQPQqV9ocMA:9 > a=Ps3mTcVvHI0M6VU3s1wA:7 a=CjuIK1q_8ugA:10 > a=A3duGc4wJ8K8BtNzzvyz4A==:117 > X-Virus-Scanned: by XS4ALL Virus Scanner > X-XS4ALL-Spam-Score: 0.0 () none > X-XS4ALL-Spam: NO > Envelope-To: mark.kette...@xs4all.nl > > On Fri, Apr 22, 2011 at 03:50:28PM +0200, Mark Kettenis wrote: > > > =================================================================== > > > RCS file: /cvs/src/lib/libc/shlib_version,v > > > retrieving revision 1.128 > > > diff -u -p -r1.128 shlib_version > > > @@ -1,4 +1,4 @@ > > > -major=58 > > > +major=59 > > > minor=1 > > > # note: If changes were made to include/thread_private.h or if system > > > # calls were added/changed then libpthread must also be updated. > > > > Since you're only adding new functions, you should bump the minor > > instead of the major. > > > > Also, note that if you do bump the major, you should reset the minor to 0. > > > > > Index: gnu/lib/libstdc++-v3/shlib_version > > > =================================================================== > > > RCS file: /cvs/src/gnu/lib/libstdc++-v3/shlib_version,v > > > retrieving revision 1.1 > > > diff -u -p -r1.1 shlib_version > > > @@ -1,2 +1,2 @@ > > > -major=50 > > > +major=51 > > > minor=0 > > > > Here, bumping the major is probably the right thing to do, since the > > availability of wprintf is likely to affect the ABI through autoconf > > magic that is difficult to track. > > Thanks, here's a proper bump diff: > > Index: lib/libc/shlib_version > =================================================================== > RCS file: /cvs/src/lib/libc/shlib_version,v > retrieving revision 1.128 > diff -u -p -r1.128 shlib_version > @@ -1,4 +1,4 @@ > major=58 > -minor=1 > +minor=2 > # note: If changes were made to include/thread_private.h or if system > # calls were added/changed then libpthread must also be updated. > Index: gnu/lib/libstdc++-v3/shlib_version > =================================================================== > RCS file: /cvs/src/gnu/lib/libstdc++-v3/shlib_version,v > retrieving revision 1.1 > diff -u -p -r1.1 shlib_version > @@ -1,2 +1,2 @@ > -major=50 > +major=51 > minor=0
With that change, the diff is ok kettenis@, assuming this is all done in coordination with the ports people
