clearing these is now utterly pointless, was only done for statistics
before.
moreover, clearing these might even lead to a pointless re-check in
software in some scenarios.
note that these flags have nothing at all to do with the outbound side,
i. e. wether we have to checksum the packet.
Index: net/if_bridge.c
===================================================================
RCS file: /cvs/src/sys/net/if_bridge.c,v
retrieving revision 1.220
diff -u -p -r1.220 if_bridge.c
--- net/if_bridge.c 23 Jan 2014 23:51:29 -0000 1.220
+++ net/if_bridge.c 24 Jan 2014 00:46:11 -0000
@@ -2490,9 +2490,7 @@ bridge_ip(struct bridge_softc *sc, int d
ipstat.ips_badsum++;
goto dropit;
}
- } else
- /* XXXHB20140123 */
- m->m_pkthdr.csum_flags &= ~M_IPV4_CSUM_IN_OK;
+ }
if (ntohs(ip->ip_len) < hlen)
goto dropit;
Index: netinet/ip_input.c
===================================================================
RCS file: /cvs/src/sys/netinet/ip_input.c,v
retrieving revision 1.225
diff -u -p -r1.225 ip_input.c
--- netinet/ip_input.c 23 Jan 2014 23:51:29 -0000 1.225
+++ netinet/ip_input.c 24 Jan 2014 00:47:04 -0000
@@ -283,9 +283,7 @@ ipv4_input(struct mbuf *m)
ipstat.ips_badsum++;
goto bad;
}
- } else
- /* XXXHB20140123 */
- m->m_pkthdr.csum_flags &= ~M_IPV4_CSUM_IN_OK;
+ }
/* Retrieve the packet length. */
len = ntohs(ip->ip_len);
Index: netinet/tcp_input.c
===================================================================
RCS file: /cvs/src/sys/netinet/tcp_input.c,v
retrieving revision 1.271
diff -u -p -r1.271 tcp_input.c
--- netinet/tcp_input.c 23 Jan 2014 23:51:29 -0000 1.271
+++ netinet/tcp_input.c 24 Jan 2014 00:47:22 -0000
@@ -533,9 +533,7 @@ tcp_input(struct mbuf *m, ...)
tcpstat.tcps_rcvbadsum++;
goto drop;
}
- } else
- /* XXXHB20140123 */
- m->m_pkthdr.csum_flags &= ~M_TCP_CSUM_IN_OK;
+ }
/*
* Check that TCP offset makes sense,
Index: netinet/udp_usrreq.c
===================================================================
RCS file: /cvs/src/sys/netinet/udp_usrreq.c,v
retrieving revision 1.173
diff -u -p -r1.173 udp_usrreq.c
--- netinet/udp_usrreq.c 23 Jan 2014 23:51:29 -0000 1.173
+++ netinet/udp_usrreq.c 24 Jan 2014 00:47:43 -0000
@@ -308,9 +308,7 @@ udp_input(struct mbuf *m, ...)
udpstat.udps_badsum++;
goto bad;
}
- } else
- /* XXXHB20140123 */
- m->m_pkthdr.csum_flags &= ~M_UDP_CSUM_IN_OK;
+ }
}
#ifdef IPSEC
--
Henning Brauer, h...@bsws.de, henn...@openbsd.org
BS Web Services GmbH, http://bsws.de, Full-Service ISP
Secure Hosting, Mail and DNS Services. Dedicated Servers, Root to Fully Managed
Henning Brauer Consulting, http://henningbrauer.com/
