Essentially fixes for clang warnings.  Clang doesn't like the

            sc = sc;

statements in dwc2_shutdown(), dwc2_childdet() and dwc2_activate().
Those functions aren't actually used.  This diff moves them inside the
#if 0 that's already there for dwc2_suspend() and dwc2_resume().  But
perhaps I should just remove the code altogether?


Index: dev/usb/dwc2/dwc2.c
===================================================================
RCS file: /cvs/src/sys/dev/usb/dwc2/dwc2.c,v
retrieving revision 1.37
diff -u -p -r1.37 dwc2.c
--- dev/usb/dwc2/dwc2.c 15 Sep 2016 02:00:18 -0000      1.37
+++ dev/usb/dwc2/dwc2.c 23 Sep 2016 11:43:30 -0000
@@ -1493,6 +1493,7 @@ dwc2_detach(struct dwc2_softc *sc, int f
        return rv;
 }
 
+#if 0
 bool
 dwc2_shutdown(struct device *self, int flags)
 {
@@ -1521,7 +1522,6 @@ dwc2_activate(struct device *self, int a
        return 0;
 }
 
-#if 0
 bool
 dwc2_resume(struct device *dv, const pmf_qual_t *qual)
 {
Index: dev/usb/dwc2/dwc2var.h
===================================================================
RCS file: /cvs/src/sys/dev/usb/dwc2/dwc2var.h,v
retrieving revision 1.16
diff -u -p -r1.16 dwc2var.h
--- dev/usb/dwc2/dwc2var.h      3 Sep 2015 14:22:27 -0000       1.16
+++ dev/usb/dwc2/dwc2var.h      23 Sep 2016 11:43:30 -0000
@@ -120,10 +120,10 @@ int               dwc2_dma_config(struct dwc2_softc *
                                struct dwc2_core_dma_config *);
 int            dwc2_intr(void *);
 int            dwc2_detach(dwc2_softc_t *, int);
+#if 0
 bool           dwc2_shutdown(struct device *, int);
 void           dwc2_childdet(struct device *, struct device *);
 int            dwc2_activate(struct device *, int);
-#if 0
 bool           dwc2_resume(struct device *, const pmf_qual_t *);
 bool           dwc2_suspend(struct device *, const pmf_qual_t *);
 #endif

Reply via email to