Most of these are fatal and log_debug. Keep the __func__ there! But we’ll remove it from other logging functions where it was never intended to be used and potentially reword the warnings nicely.
Reyk > Am 28.10.2018 um 00:39 schrieb Ori Bernstein <o...@eigenstate.org>: > >> On Sat, 27 Oct 2018 16:15:32 -0600, "Theo de Raadt" <dera...@openbsd.org> >> wrote: >> >> I quite dislike when software uses __func__ to tell me what internal >> function had an error. >> >> Why should a user see an error with the string virtio_qcow2_get_base, >> qc2_open, qc2_pwrite, etc? >> >> It feels unpolished. >> > > Possibly, but it is consistent with the rest of vmd (16 instances are > from vioqcow2.c) > > $ grep log.*__func__ *.c | wc -l > 162 > > But many of them are on lines that wrap. Overcounting a bit: > > $ grep __func__ *.c | wc -l > 474 > > If we want to change it, I think it's better as an independent patch that > converts all of vmd. > > -- > Ori Bernstein >
