On 2020-12-18, Martijn van Duren wrote:
> So I ended up in doas again, this time with the CFLAGS I use for most of
> my other projects. This popped up a few new not very exciting warnings.
> Diff below compiles clean with both clang and gcc on amd64.
 
>  static int
>  match(uid_t uid, gid_t *groups, int ngroups, uid_t target, const char *cmd,
> -    const char **cmdargs, struct rule *r)
> +    const char * const*cmdargs, struct rule *r)

That looks ugly, and I don't see the point. Const on the char prevents bugs,
but after that we're just piling on crap.

Reply via email to