On Wed, Apr 01, 2009 at 12:20:37PM -0500, DRC wrote: > > As for OML, I take it you want to replace the existing SSE2 code as > > well? > > > We wouldn't necessarily have to. We could use OML only for 64-bit, for now.
It doesn't look fine for me to use different approaches for 32bit and 64bit platforms. > >> Essentially, I think it would take me less time to introduce the Open > >> mediaLib routines into libjpeg/SIMD than it would to modify the assembly > >> code to support multiple pixel formats. > >> > > > > Bringing in another complex lib into the build right now makes me a bit > > uneasy. I'd prefer if we could wait until after the release to start > > looking at OML and if the benefits outweigh the costs. > > > > The number of combinations for pixel formats aren't that many. Can't we > > just automatically generate one function per combination? That design > > should fit with how the code is written right now. > > > There's a lot of risk in releasing a 64-bit port of libjpeg/SIMD as > well. I understand the desire to constrain that risk to only the 64-bit > code path, which we could easily do by using OML only for 64-bit. I > think that doing that is, in fact, less risky than a 64-bit libjpeg/SIMD > port. The only other option is to not have acceleration for 64-bit, and > I don't like that idea. > > Also, irrespective of 64-bit, I still need help figuring out the problem > below. I think the best solution will be defer 64bit acceleration to 1.1.0 because it will be non trivial change. After 1.0.0 release we will decide if we want to use ASM code for each platform or OML. I agree it would be better to have 64bit acceleration working in 1.0.0 but as I wrote above it will take a long time and we already have many new features compared to tightvnc trunk. Regards, Adam -- Adam Tkac, Red Hat, Inc. ------------------------------------------------------------------------------ _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
