On Wed, Jul 21, 2010 at 10:16:59AM +0200, Adam Tkac wrote:
> > | bool SSecurityFactoryTLS::isSecTypeSupported(rdr::U32 secType) {
> > |   switch (secType) {
> > | #ifdef HAVE_GNUTLS
> > |   case secTypePlain:
> > |   case secTypeTLSNone:
> > |   case secTypeTLSVnc:
> > |   case secTypeTLSPlain:
> > |   case secTypeX509None:
> > |   case secTypeX509Vnc:
> > |   case secTypeX509Plain:
> > |   case secTypeVeNCrypt:
> > | #endif
> > |     return true;
> > |   default:
> > |     return SSecurityFactoryStandard::isSecTypeSupported(secType);
> > |   }
> > | }
> 
> You are right, current code in TigerVNC trunk is stricter than
> VeNCrypt. However I tried to test original VeNCrypt code and gtk-vnc
> implementation (which implements VeNCrypt and popular vinagre client
> is based on it) and vinagre can't cope with "standard" security
> types as VeNCrypt subtypes.

Welcome to the fragmented VNC world :-( 
What kind of VNC implementations should be considered important?

> Do you think this functionality is really useful? From my point of
> view, when there is no interesection between VeNCrypt subtypes between
> client & server then client can simply not use VeNCrypt and use
> standard security type, can't it?

I see the main advantage of enabling standard types, that it will
allow the server to honor the order in the SecurityTypes parameter by
the users (=> it works transparent as specified in the parameter - the
user must not know that VncAuth/None will be selected before/after all
extended security types and must not cope with the problem you
described above).

eg. 
-SecurityTypes TLSVnc,VncAuth,X509Vnc
=>
  VeNCrypt,VncAuth as Security types for SConnection
  TLSVnc,VncAuth,X509Vnc as Security types for VeNCrypt

If there is no VeNCrypt in the client, it will use VncAuth.
If there is VeNCrypt support, it will use the TLSVnc,VncAuth,X509Vnc
order.

Regards,
Martin Kögler

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to