On 26 Apr 2001 [EMAIL PROTECTED] wrote:

>
>   Each Store now have the ability to implement their own processExpires()
>   and storeStart()/storeStop().
>   

The typical design pattern for most subclassable components in Catalina is
to have the subclass simply override the methods it needs to, with an
appropriate call to the superclass method.  For example, FileStore would
implement:

  public void start() throws LifecycleException {
    ... stuff before superclass start() is called ...
    super.start();
    ... stuff after superclass start() is called ...
  }

I'd prefer if we used that pattern here as well.

While you are at it, the current convention in Tomcat is to use spaces
rather than embedded tabs for indentation.  I know some of the old code
that you cut and pasted from probably had tabs in it, but new code (and
patches to old code) should use spaces instead.

Craig

Reply via email to