cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpResponseBase.java

[remm]

remm        02/01/27 15:47:36

  Modified:    catalina/src/share/org/apache/catalina/connector
                        HttpResponseBase.java
  Log:
  - Fix 5876: Avoid possible thread safety problems when using date headers.
  
  Revision  Changes    Path
  1.44      +16 -8     
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java
  
  Index: HttpResponseBase.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- HttpResponseBase.java     5 Jan 2002 22:39:12 -0000       1.43
  +++ HttpResponseBase.java     27 Jan 2002 23:47:36 -0000      1.44
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v
 1.43 2002/01/05 22:39:12 larryi Exp $
  - * $Revision: 1.43 $
  - * $Date: 2002/01/05 22:39:12 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v
 1.44 2002/01/27 23:47:36 remm Exp $
  + * $Revision: 1.44 $
  + * $Date: 2002/01/27 23:47:36 $
    *
    * ====================================================================
    *
  @@ -103,7 +103,7 @@
    *
    * @author Craig R. McClanahan
    * @author Remy Maucherat
  - * @version $Revision: 1.43 $ $Date: 2002/01/05 22:39:12 $
  + * @version $Revision: 1.44 $ $Date: 2002/01/27 23:47:36 $
    */
   
   public class HttpResponseBase
  @@ -123,6 +123,17 @@
           }                                                             
       }
   
  +
  +    // ----------------------------------------------------------- Constructors
  +
  +
  +    public HttpResponseBase() {
  +
  +        format.setTimeZone(TimeZone.getTimeZone("GMT"));
  +
  +    }
  +
  +
       // ----------------------------------------------------- Instance Variables
   
   
  @@ -135,11 +146,8 @@
       /**
        * The date format we will use for creating date headers.
        */
  -    protected static final SimpleDateFormat format =
  +    protected final SimpleDateFormat format =
           new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz",Locale.US);
  -    static {
  -        format.setTimeZone(TimeZone.getTimeZone("GMT"));
  -    };
   
   
       /**
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>