----- Original Message -----
From: "George Sexton" <[EMAIL PROTECTED]>
To: "'Tomcat Developers List'" <tomcat-dev@jakarta.apache.org>
Sent: Sunday, June 05, 2005 8:53 AM
Subject: RE: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper
HostMap.java Mapper.java
-----Original Message-----
From: Bill Barker [mailto:[EMAIL PROTECTED]
Sent: Saturday, June 04, 2005 1:27 PM
To: Tomcat Developers List
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt
p/mapper HostMap.java Mapper.java
----- Original Message -----
From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Saturday, June 04, 2005 10:29 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt
p/mapper
HostMap.java Mapper.java
>Peter Rossbach wrote:
>> Hey Remy,
>>
>> For usefull feature I don't give up :-)
>
>Fine, I'll just revert your patch then ;)
>
>> The default of host alias matching is off. The current
implementation is
>> little bit fast
>> then the old one. (Great) Every user of this feature can limit the
>> dynamic host addition with
>> <Connector port="8080" allowedAliasMatches="10" />
>
>The issue is that this mechanism is bad, period.
I have to agree with Remy on this. The issue is that the
code is just plain
bad :(. So I'm going to add my -1 to the patch until the
There's no justification here. Explain why you think the code is "bad"
it's
actually a hell of a lot cleaner and easier to follow than the original
code, and it's 15% faster. What exactly are your criteria for measuring
goodness.
Well, the gratuitous cloning of the HostMap is bad for one. It looks like
an attempt to avoid a sync in a non-critial path, but of course it can't
possibly work.
Before I could move to +1, the code would have to be (like Remy says) a lot
more generic. Especially with pre-compiled JSPs, there are a lot of cases
where you'd get a lot more bang doing this type of optimization for
servlet-mappings than for Hosts.
mechanism is
cleaned up. In fact, I'd have -1ed it just for the "import
com.sun....."
line alone.
I don't know what you are looking at. My submission had NO com.sun.xxx
class
imports.
I'm looking at the commit message, obviously. That's what we are voting on
;-).
Perhaps you missed the thread where I said I rewrote it?
http://www.mhsoftware.com/~gsexton/HostMap.java
http://www.mhsoftware.com/~gsexton/Mapper.java
If you are going to -1 some code, you should at least look at it.
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
This message is intended only for the use of the person(s) listed above as the
intended recipient(s), and may contain information that is PRIVILEGED and
CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or
distribute this message or any attachment. If you received this communication
in error, please notify us immediately by e-mail and then delete all copies of
this message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through
the Internet is not secure. Do not send confidential or sensitive information,
such as social security numbers, account numbers, personal identification
numbers and passwords, to us via ordinary (unencrypted) e-mail.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
