[
https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471448
]
Frank Budinsky commented on TUSCANY-1086:
-----------------------------------------
Thanks for doing this Hasan.
In general it looks very good, with one exception. In HelperProviderImpl you
changed this:
xmlHelper.save(dataObject, "commonj.sdo", "dataObject",
gzipOutputStream);
to this:
xmlHelper.save(dataObject, null, "dataObject", gzipOutputStream);
I believe that "commonj.sdo" is right, and wonder why you changed it. I suspect
that if it doesn't work, we should figure out why not, and fix that.
Also, can you please fix the JUnit to use a ByteStream instead of creating a
dummy file ("temporaryFile") in the file system? The formatting (indentation)
of the JUnit is also all messed up. Please remember that this is an open
"source" project so the source code is part of the product and should be nice
and polished.
Thanks,
Frank.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: JavaSerDeserialization.patch,
> JavaSerDeserialize_NewFiles_TestCase.zip, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's.
> Currently it can be done only in the Global/default scope. Have to fix this
> by using helperContext as the scope for creating ObjectInputStream and
> ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
