[
https://issues.apache.org/jira/browse/TUSCANY-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491618
]
Amita Vadhavkar commented on TUSCANY-952:
-----------------------------------------
1)For the first issue regarding QualifiedColumn constructor:-
QualifiedColumn(String name, boolean isDatabaseSchemaNameSupported), below is
the explaination:-
In QualifiesColumn - what is expected in name parameter is
tableName.columnName - at the least.
When multiple schema support is ON, the name parameter is expected to have
schemaName.tableName.columnName.
So in both the cases tableName.columnName is the minimum requirement. Thus
invoking the
constructor like QualifiedColumn("table", false) does not follow the minimum
requirement,
because irrespective of multi-schema support, at least one '.' needs to be
there in 'name'.
With this the current logic in the code looks OK, if it throws RuntimeException
for
new QualifiedColumn("table", false)
2) For second issue regarding
MappingWrapper.addRelationship(Vector, Vector) -
work-in-progress
3) addConverter(String name, String converter) - the existing code will as such
work correct, as
findOrCreateTable(column) is using QualifiedColumn which has schemaName
information as a member
variable.
Still, will clean code and will add more comments.
4) As mentioned during last patch submission, work-in-progress for a J2SE test
client having the test cases
mentioned in the documentation. It will be there in the next patch along with
issue resolution for 2) and 3).
The unit test cases are not added to the rdb core test suite as, the current
unit tests' db , table creation - does
not support the multi-schema condition, and instead of scattering many new
tables,scema, classes in the unit tests, same test cases will be shown using a
separate J2SE test client sample. For unit testing, this sample can be modified
and tested.
> DAS must support queries that reference tables in different "schemas"
> ---------------------------------------------------------------------
>
> Key: TUSCANY-952
> URL: https://issues.apache.org/jira/browse/TUSCANY-952
> Project: Tuscany
> Issue Type: Bug
> Components: Java DAS RDB
> Reporter: Kevin Williams
> Fix For: Java-DAS-Mx
>
> Attachments: DAS-JIRA-952-Apr24-Amita.txt, JIRA-952-Details.doc,
> JIRA-952-Feb16-Amita.jar, JIRA-952-Mar01-Amita.jar
>
>
> The DAS is curently ignorant of database schema designations. This means the
> DAS will generate incorrect write statements when it processes the change
> summary from a data graph that originated from a query that uses schema names
> that are different from the default schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
