I can confirm that the test works ok now for me.
...ant
On Thu, Jun 12, 2008 at 11:33 AM, Simon Nash <[EMAIL PROTECTED]> wrote:
> Simon Nash wrote:
>
>> Raymond Feng wrote:
>>
>>> Hi,
>>>
>>> Do any of you see this failure too?
>>>
>>> Yes, I see it. It appears the test is wrong, and this is now showing
>> up because of my recent check-in r666738 in which I fixed a problem
>> where the conversation object was incorrectly being returned as null
>> even though there is an active conversation.
>>
>> This test appears to be checking for the incorrect behaviour. The
>> call b.testNullConversation() creates a conversation, since the
>> BComponent interface is @Conversational and BComponentImpl has
>> @Scope("CONVERSATION"). Calling RequestContext.getConversation()
>> while this method is active should return non-null, not null.
>>
>> I fixed this test case under r667036.
>
> Simon
>
> Simon
>>
>> Thanks,
>>> Raymond
>>>
>>> org.apache.tuscany.sca.vtest.javaapi.apis.callablereference.CallableReferenceTestCase.testGetConversation()
>>>
>>>
>>> java.lang.AssertionError: at org.junit.Assert.fail(Assert.java:69)
>>> at org.junit.Assert.assertTrue(Assert.java:32)
>>> at org.junit.Assert.assertNull(Assert.java:256)
>>> at org.junit.Assert.assertNull(Assert.java:265)
>>> at
>>> org.apache.tuscany.sca.vtest.javaapi.apis.callablereference.impl.BComponentImpl.testNullConversation(BComponentImpl.java:67)
>>>
>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> at
>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>
>>> at
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>
>>> at java.lang.reflect.Method.invoke(Method.java:597)
>>> at
>>> org.apache.tuscany.sca.implementation.java.invocation.JavaImplementationInvoker.invoke(JavaImplementationInvoker.java:133)
>>>
>>> at
>>> org.apache.tuscany.sca.binding.sca.impl.SCABindingInvoker.invoke(SCABindingInvoker.java:61)
>>>
>>> at
>>> org.apache.tuscany.sca.core.invocation.JDKInvocationHandler.invoke(JDKInvocationHandler.java:286)
>>>
>>> at
>>> org.apache.tuscany.sca.core.invocation.JDKInvocationHandler.invoke(JDKInvocationHandler.java:154)
>>>
>>> at $Proxy14.testNullConversation(Unknown Source)
>>> at
>>> org.apache.tuscany.sca.vtest.javaapi.apis.callablereference.CallableReferenceTestCase.testGetConversation(CallableReferenceTestCase.java:103)
>>>
>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> at
>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>
>>> at
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>
>>> at java.lang.reflect.Method.invoke(Method.java:597)
>>> at
>>> org.junit.internal.runners.TestMethodRunner.executeMethodBody(TestMethodRunner.java:99)
>>>
>>> at
>>> org.junit.internal.runners.TestMethodRunner.runUnprotected(TestMethodRunner.java:81)
>>>
>>> at
>>> org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
>>>
>>> at
>>> org.junit.internal.runners.TestMethodRunner.runMethod(TestMethodRunner.java:75)
>>>
>>> at
>>> org.junit.internal.runners.TestMethodRunner.run(TestMethodRunner.java:45)
>>> at
>>> org.junit.internal.runners.TestClassMethodsRunner.invokeTestMethod(TestClassMethodsRunner.java:75)
>>>
>>> at
>>> org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:36)
>>>
>>> at
>>> org.junit.internal.runners.TestClassRunner$1.runUnprotected(TestClassRunner.java:42)
>>>
>>> at
>>> org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
>>>
>>> at
>>> org.junit.internal.runners.TestClassRunner.run(TestClassRunner.java:52)
>>> at
>>> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:38)
>>>
>>> at
>>> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>>>
>>> at
>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
>>>
>>> at
>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
>>>
>>> at
>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
>>>
>>> at
>>> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
>>>
>>>
>>>
>>>
>>
>>
>
