Dear Matthias,
in message <[EMAIL PROTECTED]> you wrote:
>
> as you might have noticed the DU440 board is havily based on seuqoia code.
No, I wasn't aware of this.
> Nearly all of your comments apply to that board as well. I thought of the
> sequoia code as exemplary reference code. And I prefer not to reformat
> comments
> when copy and pasting from one board to another.
Hm. So I have to talk with the maintainer of this board - especially
how he managed to run this through the custodian without public
review. Stefan, how did he bribe you? :-)
> But if you really insist of these changes I will change the patch.
Please do. Ideally, please include the Sequoia in your cleanup, too.
> > > +#if 0
> > > +/*
> > > + * test commands for SM722 2D acceleration
> > > + */
> > ...
> > > +U_BOOT_CMD(
> > > + gfxline, CFG_MAXARGS, 1, do_gfxline,
> > > + "gfxline - draw line\n",
> > > + "[color] [x1] [y1] [x2] [y2]\n"
> > > + );
> > > +#endif
> >
> > Please remove the dead code.
> Please not. The DU440 board will get an updated smi_lynxem driver with
> support for the
> SM722 soon. My current hack is to dirty for submission and I just got some
> more register
> dumps from SM to support more videomodes. I will need this commented out code
> to test it.
> I plan to remove it later.
Please remove it. We use source code management systems to maintain
test code etc. If it's "#if 0" is has no place in the public code.
> > You probably may want to adjust the (C) messages in some other files,
> > too.
> Ack. May I put my name on it? The source of this code has no copyright either.
Stefan???
> > > + __bss_start = .;
> > > + .bss :
> >
> > NOLOAD attribute missing. Please fix.
> This is new to me. But I just noticed that all other boards have been updated
> according to this. So will I.
Thanks.
> I will update my patches. Perhaps you can comment on my comments above.
Done :-)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Ernest asks Frank how long he has been working for the company.
"Ever since they threatened to fire me."
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
