In message <[EMAIL PROTECTED]> you wrote:
...
> + while( pattern[i] != 0)
> + {
Incorrect brace style. Also incorrect white space. U-Boot requires:
while (pattern[i] != 0) {
> + if( read_value != pattern[i]){
Please add a space before the '(' and '{', and remove the apce after
the '('.
> + post_log("FPGA Memory test failed write %08X, read %08X
> at address %08X\n",
Line too long.
> @@ -87,7 +129,16 @@ int fpga_post_test(int flags)
>
> read_value = get_ram_size((void *)CFG_FPGA_BASE_1, 0x4000);
> post_log("FPGA RAM size: %d bytes\n", read_value);
> -
> +
Please do not add trailing white space.
> + for(address = 0; address < 0x1000; address++)
> + {
Brace style, white space.
> + if( fpga_mem_test((void *) (FPGA_RAM_START + 4*address)) == 1){
White space.
> + ret = 1;
> + goto out;
> + }
> + };
No semicolon here, please.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
To be a winner, all you need to give is all you have.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
