Dear "prodyut hazarika",
In message <[EMAIL PROTECTED]> you wrote:
>
> > > But then, you are changing good TAB chanracters that were used for
> > > vertical alignment into spaces. This is incorrect - please read the
> > > Coding Style requirements.
> > >
> > > Please do not do this.
>
> The problem is that lot of existing code use spaces to align the
> defines. You can see include/ppc4xx.h and lot of other header files. I
> have seen that spaces are used only in defines. As an example in
> ppc4xx.h. I can send thousands of other places.:
>
> #if defined(CONFIG_405EX) || \$
> defined(CONFIG_440SP) || defined(CONFIG_440SPE) || \$
> defined(CONFIG_460EX) || defined(CONFIG_460GT)$
> #define CONFIG_SDRAM_PPC4xx_IBM_DDR2^I/* IBM DDR(2) controller */$
> #endif$
Here it makes sense to align the 'define's vertically, and it seems
obvious that only spaces can be used here.
Yes, I am aware that there are lots of bad examples around, but please
take the good ones as a guide, not the bad ones.
Finally, no matter what any examples were that you might have followed
when writing new code. What I am complaining about is that you changed
good code and converted it into bad one.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Quotation, n. The act of repeating erroneously the words of another.
The words erroneously repeated.
- Ambrose Bierce _The Devil's Dictionary_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
