Dear Benoît Thébaudeau, > Hi Marek, > > On Friday, March 8, 2013 4:29:00 AM, Marek Vasut wrote: > > Dear Wolfgang Denk, > > > > > Dear Benoît Thébaudeau, > > > > > > In message > > > <1362596377-5827-15-git-send-email-benoit.thebaud...@advansee.com> > > > > you wrote: > > > > + # ... and from configs defined from other configs > > > > + s/="\(CONFIG_[A-Za-z0-9_][A-Za-z0-9_]*\)"/=$(\1)/; > > > > > > Should we not remove the lower case letters here? Such are not > > > supposed to be used in macro names. > > > > btw. CONFIG_[[:alnum:]_]\+ is shorter ;-) > > and less portable: see commit 02409f8.
$ echo -ne "=CONFIG_FOO\n=CONFIG_Bar\n=CONFIG_bAz\n" | sed "s/=\(CONFIG_[[:alnum:]_]\+\)/=$(\1)/" -bash: 1: command not found =CONFIG_FOO =CONFIG_Bar =CONFIG_bAz $ uname -a FreeBSD foo.bar.baz 8.3-RELEASE-p6 FreeBSD 8.3-RELEASE-p6 #9: Tue Feb 26 17:05:09 CET 2013 f...@bar.baz.foo:/usr/obj/usr/src/sys/XXXXX amd64 I dont exactly understand the commit message, it works on this freebsd box. I won't go digging through the CVSes to find when it was added though ;-) Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot