On 06/18/13 19:28, Robert Winkler wrote: > I figured this one was so simple it didn't warrant anything more than > what's already in the subject line.
Yes, that's understood. There are plenty of simple patches, but still it is a good practice to have even a minimal commit message. > > On Mon, Jun 17, 2013 at 11:26 PM, Igor Grinberg <grinb...@compulab.co.il> > wrote: >> >> On 06/17/13 21:31, Robert Winkler wrote: >>> Signed-off-by: Robert Winkler <robert.wink...@boundarydevices.com> >> >> Usually, we add something to the commit message, otherwise >> Acked-by: Igor Grinberg <grinb...@compulab.co.il> >> >>> --- >>> board/compulab/cm_t35/cm_t35.c | 2 +- >>> include/configs/cm_t35.h | 1 - >>> 2 files changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c >>> index b0b80e5..95098af 100644 >>> --- a/board/compulab/cm_t35/cm_t35.c >>> +++ b/board/compulab/cm_t35/cm_t35.c >>> @@ -120,7 +120,7 @@ static inline int splash_load_from_nand(void) >>> } >>> #endif /* CONFIG_CMD_NAND */ >>> >>> -int board_splash_screen_prepare(void) >>> +int splash_screen_prepare(void) >>> { >>> char *env_splashimage_value; >>> u32 bmp_load_addr; >>> diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h >>> index c6e357a..b258da9 100644 >>> --- a/include/configs/cm_t35.h >>> +++ b/include/configs/cm_t35.h >>> @@ -339,6 +339,5 @@ >>> #define CONFIG_SPLASH_SCREEN >>> #define CONFIG_CMD_BMP >>> #define CONFIG_BMP_16BPP >>> -#define CONFIG_SPLASH_SCREEN_PREPARE >>> >>> #endif /* __CONFIG_H */ >>> >> >> -- >> Regards, >> Igor. > -- Regards, Igor. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot