On 09/03/2014 11:30 AM, Peter A. Bigot wrote:
On 09/03/2014 11:52 AM, Stephen Warren wrote:
On 09/03/2014 10:32 AM, Peter A. Bigot wrote:
The code to set the MMC partition uses an weak function to obtain the
correct partition number. Use that instead of the compile-time default
when deciding whether it needs to switch back.
Yes, this clearly fixes a bug.
Can you also please add a Fixes: tag that refers to the commit which
introduced the problem (i.e. which updated mmc_set_env_part() to call
mmc_get_env_part(), but forgot to update fini_mmc_for_env() to match.
Done.
If this tag is important enough to ask people to add it and resubmit
their patches with no other changes, it should probably be described at
http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags and
suggested in the section on general patch submission rules, so the poor
contributor might have a chance of being able to avoid the rework.
I'd expect that if the only issue was a patch was a missing fixes line,
the person applying the patch could manually edit it in when applying
the patch, so all the contributor would have to do is reply to the email
with the desired content. Still, different committers have different
levels of tolerance for this, so YMMV!
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
