On 22:42 Thu 23 Jul , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090723202252.ga9...@game.jcrosoft.org> you wrote: > > > > > Sorry if I have to ask, but I mostly lost track of the discussion. It > > > seems you reject these patches just because you dislike the naming of > > > some file-local data structures and variables? > > not because I do not like it because there are not safe and must be omap3 > > specific and not generic for soc specific struct > > We don't make any such restrictions in other, similar header files. > Adding (artifical) prefixes like omap3_ as you requested just makes > it more likely thatthe some declarations and code will be repeated > elsewhere, just with a different name. > > If you have a specific example, where you see existing or even likely > name conflicts, then please show it. Otherwise I suggest we just > leave the code as is. yes I have as we prepapre a gpio generic api for our need, which we will push Mainline we must not make omap3 so generic we face the same problem with last stdio cleanup
so for this patch series is not an improvment but a regression Best Regards, J. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot