On Wed, 2009-12-16 at 14:48 +0530, Vipin KUMAR wrote: > Signed-off-by: Vipin <vipin.ku...@st.com> > --- > board/spear/common/spr_lowlevel_init.S | 202 ++++++++++++++++++ > board/spear/common/spr_misc.c | 270 > ++++++++++++++++++++++++ > board/spear/spear600/Makefile | 52 +++++ > board/spear/spear600/config.mk | 39 ++++ > board/spear/spear600/spr600_board.c | 53 +++++ The changes to board/* should be moved out of this patch and into patch 9 "SPEAr600 build support added". Same comment for include/configs/spear600.h.
> common/cmd_bdinfo.c | 20 ++ > cpu/arm926ejs/spear/Makefile | 52 +++++ > cpu/arm926ejs/spear/reset.c | 49 +++++ > cpu/arm926ejs/spear/timer.c | 148 +++++++++++++ > include/asm-arm/arch-spear/spr_defs.h | 31 +++ > include/asm-arm/arch-spear/spr_emi.h | 55 +++++ > include/asm-arm/arch-spear/spr_gpt.h | 83 ++++++++ > include/asm-arm/arch-spear/spr_syscntl.h | 38 ++++ > include/asm-arm/arch-spear/spr_xloader_table.h | 67 ++++++ > include/asm-arm/u-boot.h | 5 + > include/configs/spear600.h | 260 +++++++++++++++++++++++ It'd also be nice to give a description of each board and SOC you add. Eg what's the difference between the 300, 310, 320, 600? What peripherals do they support? What does SPEAr stand for? More commit messages in general wouldn't hurt:) Best, Peter _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
