Hi Robert (and Michael), First, thanks for the original review so long ago. I finally had a chance to look at this again, and I think I have fixed all the issues you pointed out. I've proposed the new branch for reviewing/merging. The point about the values that scanners expect differing makes sense, so I implemented scaling for the values. I thought I based the original range off of what mine expected, but apparently not as that turns out to be -127 to 127. Anyways, as long as no scanners expect extremely large values, the scaling should work. It now only sets the value if it is changed from default as you mentioned, so there is always that to fall back on.
Lastly, as part of the change from gtk2 to gtk3 it looks like the trough-side-details property was dropped (http://git.gnome.org/browse/gtk+/commit/?id=658f99b8eef2805f2f4ca18c9436931e8d225b26), so I don't think I can fix it drawing the misleading background highlighting anymore for the scales. I looked to see if there was a way to tell it to draw the highlight/fill from the middle, but I couldn't find anything. Setting the fill level to 0 was ignored. Setting the fill level to full would work, but then the entire background is orange and it somewhat sticks out. Oh well, I guess. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/669820 Title: Cannot set brightness or contrast To manage notifications about this bug go to: https://bugs.launchpad.net/simple-scan/+bug/669820/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
