Created attachment 713868
Store Master Password by using libsecret to Gnome Keyring patch v2

Thanks Stef for feedback. I've fixed mentioned issues.
(In reply to Stef Walter from comment #84)
> @@ +808,5 @@
> > +
> > +  secret_password_lookup(MOZILLA_SECRET_SCHEMA, nullptr, 
> > on_lookup_finished, this,
> > +                         "application", MOZ_APP_NAME,
> > +                         "profile", profileName.get(),
> > +                         NULL);
> 
> Are you sure you need to do this as async? I don't understand all aspects of
> how SyncRunnableBase works, but if this is a separate thread, you could just
> use secret_password_lookup_sync().
> 
The secret_password_lookup is called on main thread, so we have to use async 
function to update gui.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/217300

Title:
  Seahorse integration

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/217300/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to