Tormod Volden wrote: > Yes, that's how I intended it to be: Everybody should have a > #savedefault= line, and it should default to "false", except if the user > already uses "default saved" at the time this new option is introduced. > If there's already a #savedefault= line, it won't be touched. > > You will only get savedefault everywhere if you have #savedefault=true. > Don't you think this is the expected (and best) behaviour? > > We can not add savedefault boot flags just on the basis of the user > having "default saved" because the "default" line can be changed back > and forth (and should be immediately honoured at boot) without update- > grub being run to update the kernel entries. So we need the > "#savedefault=" option, that adds (or removes) the "savedefault" boot > flags to the kernel entries regardless of what "default" is set to. > > Only for the convenience of an upgrade, the "default" option will be > looked at in order to guess the best default setting for the new > "#savedefault" option. Maybe it would have been cleaner to put this > logic into an install script like grub.postinst, but having it in > update-grub makes sure this is done if the user copies an old menu.lst > from somewhere else for instance.
ACK, I think it's definitely the best way to handle this. This way upgrades through any path will work fine. Thanks for the effort! Cheers, Bart -- Update-grub does not add savedefault anymore https://bugs.launchpad.net/bugs/131858 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
