I don't think that patch actually results in any effective change at
boot time.

-      echo "   gfxmode \$linux_gfx_mode" | sed "s/^/$submenu_indentation/"
+      echo "   gfxpayload \$linux_gfx_payload" | sed 
"s/^/$submenu_indentation/"

... but gfxmode is a function, and its definition hasn't meaningfully
changed here.  All you've done is rename it.  Likewise, linux_gfx_mode
is only used within this file, and you've just changed all references to
it, so nothing actually changes.

And while in some ways it could be argued that the changed names are
less confusing, the value of GRUB's gfxpayload variable does still
describe a mode - the difference between the gfxmode and gfxpayload
variables is that the first sets the mode for GRUB's graphical terminal
while the second sets the mode that the Linux kernel starts in, but
they're still both modes, so I would definitely argue that
"linux_gfx_mode" is still a good choice of variable name.

The thing that confused you is that the "gfxmode" *function* is used to
set the "gfxpayload" *variable* (among other functions), which I'll
concede is a bit confusing.  But it doesn't make any difference to GRUB
that the argument passed to the gfxmode function isn't a valid value for
the gfxmode variable, because it isn't used to set that variable.

So ... I think you need to research this further, and the problem is
probably just that this is hardware on which gfxpayload=keep doesn't
work.  Perhaps this is a kernel bug, and/or perhaps it needs to be
blacklisted in the grub-gfxpayload-lists package (note also the update-
grub-gfxpayload manual page in that package that describes a local
workaround).

** Tags removed: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1736023

Title:
  Graphics is corrupt on VT1-VT7 even during boot

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1736023/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to