Hey Alex! Thanks for looking at it. Sure, I've added some checks for open/dup2 (and exiting the child).
On execl, I've kept the similar logic than the rest of the code, meaning: - don't check for execl return value. - if something bad happen, execl returns. - we go on the next line which is a perror() + exit. On the strrstr(), I found it more clear than the offset and future-proof than hardcoding *pname. I don't have a strong opinion though TBH, so I have just hardcoded "zsys" directly as you suggested. I've attached a new version of the patch. ** Patch added: "1015_add_zsys_support.patch" https://bugs.launchpad.net/ubuntu/+source/zsys/+bug/1842902/+attachment/5287090/+files/1015_add_zsys_support.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1842902 Title: FFe: create zfs dataset for each user automatically To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1842902/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
