Hi Bill,
On Wed, Sep 26, 2007, Bill Filler wrote:
> Can you review this patch to hildon-desktop and push it into launchpad if
> approved. Basically it adds support for dynamically hiding and showing the
> marquee panel based on an initial setting that comes out of gconf. Let me
> know if you have any questions.
Since I would be merging stuff in hildon-desktop, I was pointed at your
patch by Bob; I looked at it and applied it to the bzr tree at
bazaar.launchpad.net/~Eubuntu-mobile/hildon-desktop/ubuntu
It should work fine but some remarks:
- #defines for GConf pathnames should be moved to the .h
- you should have a schema for these gconf values
- the .conf files should be #defined and the defines moved to a .h
There are also more important issues:
- I'm not sure upstream would want to hardcode references to "marquee"
and "statusbar" in hildon-desktop; I guess they would prefer a
mechanism to tell hildon-desktop what containers to hide/show
- I understand the marquee container is specific to Ubuntu Mobile and
Moblin, and isn't used upstream
- please note that the statusbar container was dropped with the new
0.0.43 upstream release which you are using at moblin.org and which
Bob asked me to sync in Ubuntu
So while I merged the change in our branch so that Intel can use the
feature in gutsy, I think more work is needed to make it acceptable for
upstream and maintainable on the long term.
Cheers,
--
Loïc Minier
--
Ubuntu-mobile mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-mobile
