On Tuesday 08 December 2009 09:19:27 David Howells wrote: > Jie Zhang <jie.zh...@analog.com> wrote: > > I agree on using 0 instead of NULL. But for !MMU, I think, vaddr is > > always as same as addr. So we don't need to pass it? > > FRV flushes the vaddr because in MMU mode the cache flush instructions take > virtual addresses, so if we pass addr as vaddr, I can use the same cache > flush code for both modes. I suspect it makes little difference to the > amount of code if we pass that rather than 0, as the value is already > computed, and either way, it's going to take one instruction to set up the > argument. > > Note that Blackfin assumes that it may use the dst address for flushing - > an assumption that isn't valid in MMU mode with a VIVT cache (which I > presume Blackfin isn't, but other CPUs are).
the Blackfin cpu currently does not have virtual memory support at all, so i imagine there's a bunch of things that'll need updating when that day comes the new patch is of course fine; thanks -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
