On Mon, Sep 21, 2020 at 06:57:10PM +1000, Damien Mascord wrote:
> Hi guys,
> 
> To make it clearer, please see attached two commits, one for the necessary
> generic updates to allow for the BSDL to be parsed, and another to add the
> draft p1020 device support.
> 
> Please note that bus support is very draft as explained previously.
> 
> Cheers,
> 
> Damien
> 

> commit a3e6200bc6673601febc11afc08e50d94e3e4fbd
> Author: Damien Mascord <tus...@tusker.org>
> Date:   Mon Sep 21 18:50:21 2020 +1000
> 
>     Add draft support for Freescale QorIQ P1020
>      - Adds PART detection for CPU
>      - Adds initbus support for p1020
> 
> diff --git a/urjtag/configure.ac b/urjtag/configure.ac
> index 95d1d743..e1a5ae8a 100644
> --- a/urjtag/configure.ac
> +++ b/urjtag/configure.ac
> @@ -637,6 +637,7 @@ URJ_DRIVER_SET([bus], [
>       mpc824x
>       mpc8313
>       mpc837x
> +     p1020
>       ppc405ep
>       ppc440gx_ebc8
>       prototype
> diff --git a/urjtag/data/Makefile.am b/urjtag/data/Makefile.am
> index 7fb82f0f..62e916d7 100644
> --- a/urjtag/data/Makefile.am
> +++ b/urjtag/data/Makefile.am
> @@ -126,6 +126,8 @@ nobase_dist_pkgdata_DATA = \
>       freescale/mpc8378/mpc8378 \
>       freescale/mpc8379/STEPPINGS \
>       freescale/mpc8379/mpc8379 \
> +     freescale/p1020/STEPPINGS \
> +     freescale/p1020/p1020 \
>       ibm/PARTS \
>       ibm/ppc440gx/STEPPINGS \
>       ibm/ppc440gx/ppc440gx \
> diff --git a/urjtag/data/freescale/PARTS b/urjtag/data/freescale/PARTS
> index 2f5adc77..eeb7f690 100644
> --- a/urjtag/data/freescale/PARTS
> +++ b/urjtag/data/freescale/PARTS
> @@ -27,5 +27,6 @@
>  0001100011100100 mpc8378     mpc8378e
>  0001100011100011 mpc8379     mpc8379
>  0001100011100010 mpc8379     mpc8379e
> +0110100011100010 p1020               p1020
>  
>  
> diff --git a/urjtag/data/freescale/p1020/STEPPINGS 
> b/urjtag/data/freescale/p1020/STEPPINGS
> new file mode 100644
> index 00000000..3d84fc65
> --- /dev/null
> +++ b/urjtag/data/freescale/p1020/STEPPINGS
> @@ -0,0 +1,24 @@
> +#
> +# $Id: STEPPINGS
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License
> +# as published by the Free Software Foundation; either version 2
> +# of the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
> +# 02111-1307, USA.
> +#
> +# Documentation:
> +# [1] Freescale, "Freescale MPC837x Users Guide"

???


> +#
> +
> +# bits 31-28 of the Device Identification Register
> +0000 p1020           0
> diff --git a/urjtag/data/freescale/p1020/p1020 
> b/urjtag/data/freescale/p1020/p1020
> new file mode 100644
> index 00000000..9d893d86
> --- /dev/null
> +++ b/urjtag/data/freescale/p1020/p1020
> @@ -0,0 +1,1232 @@

     ...

> diff --git a/urjtag/src/bus/Makefile.am b/urjtag/src/bus/Makefile.am
> index 3a082439..3fc9c265 100644
> --- a/urjtag/src/bus/Makefile.am
> +++ b/urjtag/src/bus/Makefile.am
> @@ -122,6 +122,10 @@ if ENABLE_BUS_MPC837X
>  libbus_la_SOURCES += mpc837x.c
>  endif
>  
> +if ENABLE_BUS_P1020
> +libbus_la_SOURCES += p1020.c
> +endif
> +
>  if ENABLE_BUS_PPC405EP
>  libbus_la_SOURCES += ppc405ep.c
>  endif
> diff --git a/urjtag/src/bus/buses_list.h b/urjtag/src/bus/buses_list.h
> index aaaacc91..87728ef9 100644
> --- a/urjtag/src/bus/buses_list.h
> +++ b/urjtag/src/bus/buses_list.h
> @@ -98,6 +98,9 @@ _URJ_BUS(mpc8313)
>  #ifdef ENABLE_BUS_MPC837X
>  _URJ_BUS(mpc837x)
>  #endif
> +#ifdef ENABLE_BUS_P1020
> +_URJ_BUS(p1020)
> +#endif
>  #ifdef ENABLE_BUS_PPC405EP
>  _URJ_BUS(ppc405ep)
>  #endif
> diff --git a/urjtag/src/bus/p1020.c b/urjtag/src/bus/p1020.c
> new file mode 100644
> index 00000000..fcf4564d
> --- /dev/null
> +++ b/urjtag/src/bus/p1020.c
> @@ -0,0 +1,515 @@
> +/*
> + * Freescale P1020 compatible bus driver via BSR
> + * Copyright (C) 2010 Andrzej Jalowiecki, Damien Mascord

Seen that before, provided feedback.
Stopping with reviewing.
Rejecting the patch.


Regards
Geert Stappers

P.S.
I'm aware that other patch was in the same email.


_______________________________________________
UrJTAG-development mailing list
UrJTAG-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to