On 4/11/07, Jeff Dike <[EMAIL PROTECTED]> wrote:
> Instead of writing entire structures between UML and the I/O thread,
> we send pointers.  This cuts down on the amount of data being copied
> and possibly allows more requests to be pending between the two.
<snip>
>
> -                       n = os_write_file_k(thread_fd, (char *) &io_req,
> -                                           sizeof(io_req));
> -                       if(n != sizeof(io_req)){
> +                       n = os_write_file_k(thread_fd, &io_req,
> +                                           sizeof(struct io_thread_req *));
> +                       if(n != sizeof(struct io_thread_req *)){

Is this wrong?  you declare io_reg as a pointer but then you pass him
to os_write_file_k by  reference of a pointer? Should you just do this
instead:

> +                       n = os_write_file_k(thread_fd, io_req,
> +                                           sizeof(struct io_thread_req *));

Was this intentional, or am I just an idiot. :)

-Jerry

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Reply via email to