-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Jeff Dike wrote: > On Mon, Apr 30, 2007 at 06:18:56PM +0100, Antoine Martin wrote: >> Full marks for number of lines of code changed! (1!) > > Yeah, I thought that was a plus. > >> On the plus side, it only adds the parameter at the end, but it does >> keep some code in there to deal with variable number/order for >> [no]promisc and [no]optimized options, so I would prefer something like >> this one - not just because I wrote it ;) >> http://uml.nagafix.co.uk/pcap-macaddr.patch >> Where the only required option is the pcap filter (which is harder to >> move around since it doesn't have a fixed set of options - or does it?). > > On the negative side - > I dislike assumptions like this: Me too, but the mac address is later validated in setup_etheraddr the validation is redundant. > + //a mac address is always 17 characters long > Suppose someone uses 2:1:2:3:4:5 (11 chars), which I did for testing? I thought that was an invalid mac address?(I've never seen mac addresses specified that way on any software or hardware - yet) > This is also conflating a MAC address with a pcap option, which it > isn't. I quite liked the idea of having the freedom to specify things in any order and not having to have empty comas but no biggie.
> So what happens when someone adds more options to libpcap and UML > users start wanting to use them? I would say that we add > 'eth0=pcapv1,if,mac,filter,opt1,opt2,...' and futureproof this wrt > pcap options. People will have to rearrange their command lines in > order to use this, but they already are in order to use the new > options. Yeah, I preferred that too, it is also more consistent with the way the other transports do it, but it needed to be backwards compatible. Which can still be done, but only as long as: pcap-options!='[no]promisc!'='[no]optimize!'=mac-address='pcap' Isn't it the case already? > Everyone else will stick with the current 'eth0=pcap,...' > format. > > So, unless you have strenuous objections, I think I will stick with my > patch and wait for pcap to come up with more options. Acked-by: Antoine Martin <[EMAIL PROTECTED]> works for me (tm) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGNkPzGK2zHPGK1rsRCnCPAJ941sURMUK+XCY0DN3oC0e/I4qQowCfVoim O4TJFIvpWyNYVumoPpcinek= =AQjX -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
