On Mon, Aug 01, 2011 at 01:41:32PM +0200, Zoltan Devai wrote: > 2011/8/1 Russell King - ARM Linux <li...@arm.linux.org.uk>: > > On Sat, Jul 30, 2011 at 06:14:38PM +0200, Zoltan Devai wrote: > >> Commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b has killed off any > >> use of this config option long ago. > > > > I don't see the point of this - we were free of GENERIC_TIME on ARM > > shortly after it was originally killed off. The problem is you can't > > stop people introducing new uses of this - because it existed once and > > there's nothing which errors out on its presence, people are going to > > continue submitting patches with it in. And it's going to continue > > being missed at the review stage. > > > > I've a similar problem with folk on ARM including mach/gpio.h as their > > sole gpio header file rather than linux/gpio.h - I've been trying for > > the last 1-2 years to educate people to use linux/ in preference. You > > can't do it, and I'm still just about the only one who picks up on that. > > (SoC maintainers don't care.) They will end up caring when I push a > > change during the next merge window though, so I'll eventually stop > > mach/gpio.h being included. (Instead, it'll be asm/gpio.h). > > > > GENERIC_TIME though... I don't think you'll ever stop new uses of it > > creeping in unless you can arrange for something to error out. > > Sure, but the patch at least reduces the chances of copy-pasting it, > and makes it obvious by a simple grep that there's no use of it at all, > so I still think it's wort merging.
That argument doesn't work - as can be seen from my first paragraph. The fact that we have new references to it in arch/arm/Kconfig is proof of that. ------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel