On Tue, Feb 6, 2024 at 3:03 PM Chirag Nahata <chirag.nah...@cloudera.com> wrote:
> hey Martin, > > Thanks, This worked for me and I can confirm that I have enabled the flag > * "-Dorg.apache.avro.specific.use_custom_coders=true"* . > > Can you suggest to me how I can observe the performance improvements > before/after? > You can run your favorite profiler with your application. > > sincerely > Chirag Nahata > > On Tue, Feb 6, 2024 at 5:03 PM Martin Grigorov <mgrigo...@apache.org> > wrote: > >> >> >> On Tue, Feb 6, 2024 at 1:15 PM Siddharth Baranidharan >> <sbaranidha...@cloudera.com.invalid> wrote: >> >>> Hey Oscar, >>> Thank you for your response. >>> My application is an enterprise server(java based)-agent(python based) >>> model which uses avro-protocol for communication between server & agents. >>> To the best of my knowledge I have added the flag “- >>> *Dorg.apache.avro.specific.use_custom_coders=true*” as a java option to >>> the >>> server side. >>> >> >> You can put a breakpoint at >> https://github.com/apache/avro/blob/d143d6262f7d6c688e695d1656f8609605835604/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java#L230 >> and see what is the value of "useCustomCoderFlag" >> >> >> >>> >>> My question: >>> How can I test whether this feature is successfully enabled & to answer >>> your 2nd question, yes I want to test its effects & I am willing to trust >>> the tests that you have for the flag. Can you detail the steps I need to >>> follow for the same? >>> >>> Thank you, >>> Siddharth B >>> >>> On Tue, Feb 6, 2024 at 1:18 PM Oscar Westra van Holthe - Kind < >>> os...@westravanholthe.nl> wrote: >>> >>> > Hi, >>> > >>> > What do you mean by testing if the flag is successfully turned on? Do >>> you >>> > need to test its effects? Are you willing to trust the tests we have >>> on the >>> > flag? >>> > >>> > As for testing the performance difference, we do have a performance >>> test >>> > module. Perhaps you can use the same technique? >>> > >>> > Kind regards, >>> > Oscar >>> > >>> > -- >>> > Oscar Westra van Holthe - Kind <os...@westravanholthe.nl> >>> > >>> > Op di 6 feb. 2024 07:15 schreef chirag <nahatachirag12...@gmail.com>: >>> > >>> >> Hi Team, >>> >> >>> >> On the Avro Docs it is mentioned that:- to turn new approach to >>> generating >>> >> code that speeds up decoding and encoding set feature flag/system flag >>> >> org.apache.avro.specific.use_custom_coders to true at runtime.(here >>> >> < >>> >> >>> https://avro.apache.org/docs/1.11.1/getting-started-java/#beta-feature-generating-faster-code >>> >> > >>> >> ). >>> >> >>> >> Enquiring if: >>> >> >>> >> 1. There is a way to see if this flag is successfully turned on >>> during >>> >> runtime? >>> >> 2. There is a way to measure the performance improvement in doing >>> so? >>> >> >>> >> I have added this system flag to my distributed enterprise >>> application but >>> >> I am not sure if it is enabled and if there is a performance >>> improvement >>> >> on >>> >> doing so. >>> >> >>> >> Sincerely >>> >> Chirag Nahata >>> >> >>> > >>> >>
