Great, thanks a lot! :-) But let's negotiate one thing upfront: If we provide code that adds <encoding> to maven-dependency-plugin's <configuration>, which essentially forwards the encoding to the Plexus Unarchiver, and it looks good to you from a technical view, will you guarantee us that it will definitively up in the plugin? I have to ask that upfront because of the discussion going on here currently about the general usefulness of encodings and we must not spend any time into providing code if it ends up in the trash due to different opinions within the pluging management team. So if you can ensure this, we will lookup some people coding the solution.
Thanks! -Markus -----Ursprüngliche Nachricht----- Von: kristian.rosenv...@zenior.no [mailto:kristian.rosenv...@zenior.no] Im Auftrag von Kristian Rosenvold Gesendet: Dienstag, 17. März 2015 08:39 An: Maven Users List Betreff: Re: How to configure maven-dependency-plugin's encoding used for unpack? I'm not kidding about anything. I reopened the issue. If you make a patch that applies encoding to zip files I can review that. Kristian 2015-03-17 8:27 GMT+01:00 Markus Karg <k...@quipsy.de>: > Kristian, > > you're kidding, don't you? ;-) > > what you propose does not work. We are an ISV providing a download for > virtually anybody. We cannot tell the world "Hey, you cannot simply > use Windows to unzip, but you must first download some other > application, because we're using Maven, and it is unable to deal with > encodings.". :-( > > We are NOT packaging a "jar" file. We are packaging a "zip" file. In > fact I never mentioned "jar" AFAIK. That one is publicly downloadable. > Some team told us they use that "zip" as a dependency and need to > unpack it as part of their "prepare-package" phase (they only need > some files, not the full zip). At that moment, then file names are > turned into garbage. If there is headroom, then let's use that > headroom. All we demand is a way to tell in the POM that the plexus > "zip unarchiver" used by maven-dependency-plugin for that single > artifactItem shall use CP850. :-) > > I'm talking about http://jira.codehaus.org/browse/MDEP-436 > > Thank you for your kind help. > > Regards > -Markus > > > -----Ursprüngliche Nachricht----- > Von: kristian.rosenv...@zenior.no > [mailto:kristian.rosenv...@zenior.no] > Im Auftrag von Kristian Rosenvold > Gesendet: Montag, 16. März 2015 21:19 > An: Maven Users List > Betreff: Re: How to configure maven-dependency-plugin's encoding used > for unpack? > > There is no way to specify unarchiver encoding in the dependency > plugin, I have checked. So currently you have to make your users > install a less brain dead zip program than the windows compressed folder > mechanism. > > I am also slightly questioning of what you are trying to achieve here; > if you are unpacking a "jar" file then it *will* and *should* be UTF8, > meaning you cannot use the lobotomized zip support that is included in > windows, no matter what. I don't see us fixing /that/ issue, since > we'd be violating the jar specification. If your dependency is to an > actual "zip" file, we have slightly more headroom, and such a patch might be > applied. > > I am not sure which issue you are referring to, I know there is one > for assembly-plugin (http://jira.codehaus.org/browse/MASSEMBLY-748) > since the encoding feature should be fixed to work for "unpack" too. > > Kristian > > > > > 2015-03-16 15:04 GMT+01:00 Markus Karg <k...@quipsy.de>: > > > Kristian, > > > > can you please reopen the item then? I mean, it simply is not fixed, > > because UTF-8 ZIPs are not a solution: Windows cannot correctly > > display them, so people on the Windows world will virtually every > > create > CP850-ZIPs! > > > > Do you know about any plans to support this, or what is the intended > > future of this issue? > > > > Thanks > > -Markus > > > > -----Ursprüngliche Nachricht----- > > Von: kristian.rosenv...@zenior.no > > [mailto:kristian.rosenv...@zenior.no] > > Im Auftrag von Kristian Rosenvold > > Gesendet: Montag, 16. März 2015 13:46 > > An: Maven Users List > > Betreff: Re: How to configure maven-dependency-plugin's encoding > > used for unpack? > > > > I did not actually look at the implementation on the dependency > > plugin, but it is actually technically impossible to supply the > > encoding parameter to > > *unzip* via the <archiverConfig> tag. So until this is fixed, UTF-8 > > zip archives are the only ones that will work (with plexus unzip > archiver). > > > > Kristian > > > > > > 2015-03-16 13:05 GMT+01:00 Adrien Rivard <adrien.riv...@gmail.com>: > > > > > If I'm reading the documentation correctly, > > > <archiverConfig><encoding> only apply to filter resources, not to > > > zip > them. > > > > > > In any case I would try using utf-8. > > > > > > > > > On Mon, Mar 16, 2015 at 12:34 PM, Kristian Rosenvold < > > > kristian.rosenv...@gmail.com> wrote: > > > > > > > I dont believe there is support for specifying encoding to unzip. > > > > At > > > least > > > > assembly only provides config to zip. Call it a bug, call it a > > > > feature :( > > > > > > > > Kristian > > > > > > > > > > > > 2015-03-16 12:12 GMT+01:00 Markus Karg <k...@quipsy.de>: > > > > > > > > > To preserve German umlauts in file names within a ZIP, we are > > using... > > > > > > > > > > <archiverConfig> > > > > > <encoding>CP850</encoding> > > > > > </archiverConfig> > > > > > > > > > > ...in the maven-assembly-plugin configuration, which is > > > > > working > well. > > > :) > > > > > > > > > > Next we want to use maven-dependency-plugin to unpack that ZIP. > > > > > > > > > > How can we configure maven-dependency-plugin:unpack so it will > > > > > apply > > > > CP850 > > > > > when unpacking that ZIP? > > > > > > > > > > Thanks! > > > > > -Markus > > > > > > > > > > > > > > > > > > > > > -- > > > Adrien Rivard > > > > > >
