Does the following patch help?
--- lib/Mail/SpamAssassin/BayesStore/DBM.pm (revision 1643879)
+++ lib/Mail/SpamAssassin/BayesStore/DBM.pm (working copy)
@@ -1348,7 +1348,7 @@
if ($opts->{verbose}) {
print $msg,"\n";
} else {
- dbg($msg);
+ dbg("%s", $msg);
}
}
Ben wrote:
it doesn't appear to have made a difference. however, i am using
version 3.4.0, not revision 1643879. is that a prerequisite for this
particular patch?
Thanks for testing.
have i applied the patch properly?:
[...]
#dbg($msg);
dbg("%s", $msg);
Yes, correctly.
Actually, looking at a diff of DBM.pm between 3.4.0 and 3.4.1
I can see the taint bug has already been fixed by r1608413:
@@ -814,3 +816,3 @@
my @vars = $self->get_storage_variables();
- dbg("bayes: DB journal sync: last sync: ".$vars[7],'bayes','-1');
+ dbg("bayes: DB journal sync: last sync: %s", $vars[7]);
The extra parameters shouldn't have been in that dbg call.
See:
Bug 7065 - Debug Mode breaks Bayes but only if DBM storage is used
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7065
My today's patch can't hurt, it avoids a potential trouble,
but as it happens it may not necessary.
Mark
