2014-08-08 13:54 GMT+04:00 Willem Fibbe - Realworks BV <wil...@realworks.nl>: > Hi, > > When we upgraded our Tomcat-servers to 7.0.54, we used the new attributes of > ErrorReportValve at the Engine-level. > > Our server.xml looked like this: > > <Engine name="Catalina" defaultHost="[fqdn.here]"> > ... > <Valve > className="org.apache.catalina.valves.ErrorReportValve" showReport="false" > showServerInfo="false" /> > <Host name="[fqdn.here]"> > </Host> > </Engine> > > When we triggered an error, we saw that those attributes were working, > because we didn't see a stacktrace or > version. > > Last week we upgraded to 7.0.55 without modifying server.xml and now we see > the stacktraces and version again. > To confirm it was the upgraded Tomcat, I downgraded to 7.0.54 and indeed the > ErrorReport was working again. > > With 7.0.55 we modified our server.xml like the following to get the desired > behaviour again: > > <Engine name="Catalina" defaultHost="[fqdn.here]"> > ... > <Valve > className="org.apache.catalina.valves.ErrorReportValve" showReport="false" > showServerInfo="false" /> <!-- not necessary --> > <Host name="[fqdn.here]"> > <Valve > className="org.apache.catalina.valves.ErrorReportValve" showReport="false" > showServerInfo="false" /> <!-- necessary --> > </Host> > </Engine> > > That is, we added the Valve at the Host-level. > > Could this be a bug or did I miss something in the changelog? >
Normally an ErrorReportValve belongs to Host and is created in o.a.catalina.core.StandardHost.startInternal(). I think that in your 7.0.54 configuration is wrong and essentially means that the same error was handled twice (at Host and then at Engine). The relevant change log entry in 7.0.55 is "When an error occurs after the response has been committed close the connection immediately ..." https://svn.apache.org/r1602443 Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
