[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12432856 ] Will Glass-Husain commented on VELOCITY-453: --------------------------------------------
Hi Alexey, Looks great, thanks for submitting. Appreciate your attention to detail with code conventions as well, makes it easier to read. Two minor comments. (1) in the equals method, shouldn't the line "if (params[i] != other.params[i])" use the equals method instead? (2) Sorry to bug you on this, but we need you to resubmit "IntrospectionCacheDataTest.java" without the copyright notice. You still retain ownership of the code, but copyright notices need to go in a project-wide NOTICES file. (more info at: http://www.apache.org/legal/src-headers.html) When you have a chance to resubmit, I'll commit. > [PATCH] Fix IntrospectionCacheData caching > ------------------------------------------ > > Key: VELOCITY-453 > URL: http://issues.apache.org/jira/browse/VELOCITY-453 > Project: Velocity > Issue Type: Bug > Components: Source > Affects Versions: 1.5 > Reporter: Alexey Panchenko > Assigned To: Will Glass-Husain > Fix For: 1.5 > > Attachments: ASTMethod_IntrospectionCacheData_cache, > ASTMethod_IntrospectionCacheData_cache-v2-retry.patch, > ASTMethod_IntrospectionCacheData_cache-v2.patch, > IntrospectionCacheDataTest.java > > > The old code used Class[].hashCode() in MethodCacheKey.hashCode() > implementation. > hashCode() is not overriden for arrays so it returns different value for each > array instance. > The attached is the correct implementation and a test case to prove the > caching actually works. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
