Nazri Ramliy wrote: > On Thu, Aug 5, 2010 at 4:11 AM, Bram Moolenaar <[email protected]> wrote: > >> > I noticed another problem: with 'path' set to "./**" and in an empty > >> > buffer :find completion crashes. =A0I fixed it. > >> > >> Thanks. I'll add this check to the test script. > > I've updated the test to check for this and a few more conditions. > > > The test script works OK on Unix, but on MS-Windows it only finds two of > > the three files. Also interactively, so this appears to be a problem in > > the implementation. > > Attached patch 0002 fixes this issue. > > > I already changed it to use three separate "mkdir" commands, as "mkdir > > -p" doesn't work on MS-Windows (and some old Unixen too). > > The "mkdir Xfind/in" gives error on windows, it should be "mkdir > Xfind\in". I've modified it to work on both unix and windows in patch > 0003. > > > > > I used an edit command instead of ":!echo" to make it portable. > > > > What I can't figure out is a portable way to delete the created > > directories. "rmdir /s /q Xfind" should work, but it gives an error for > > the /s option... > > Patch 0003 checks the platform using has("win??") and runs the > appropriate command. > > Patch 0001 moves the check for path_with_url() for skipping urls during > find completion from globpath() into expand_path_option(). That is the > correct place to make the call for excluding any non-supported path for > find completion. > > test73.in should now run successfully on both unix and windows.
Thank you very much for fixing the problems and enhancing the test. I'll include this and check that it works for me. The Xfind directory wasn't removed, you had the last :cd commented-out. Hmm, the test passes, but it rings the bell a lot. I can fix one (the empty line). The others appear to be for when completion of :find fails. I'm not sure how to avoid that. I'll add ":set visualbell". -- hundred-and-one symptoms of being an internet addict: 14. You start introducing yourself as "Jim at I-I-Net dot net dot au" /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ download, build and distribute -- http://www.A-A-P.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
