patch 9.1.1979: :helpclose allows range and counts
Commit:
https://github.com/vim/vim/commit/4c141bae3bd7afd7eb63c72c835d356fbdff61e2
Author: Doug Kearns <[email protected]>
Date: Sun Dec 14 16:41:03 2025 +0100
patch 9.1.1979: :helpclose allows range and counts
Problem: :helpclose incorrectly accepts a range and a count.
Solution: Remove EX_COUNT and EX_RANGE from the command definition.
(Doug Kearns)
closes: #18917
Signed-off-by: Doug Kearns <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
diff --git a/src/ex_cmds.h b/src/ex_cmds.h
index d588be3b9..48b69ea82 100644
--- a/src/ex_cmds.h
+++ b/src/ex_cmds.h
@@ -693,8 +693,8 @@ EXCMD(CMD_help, "help", ex_help,
EX_BANG|EX_EXTRA|EX_NOTRLCOM,
ADDR_NONE),
EXCMD(CMD_helpclose, "helpclose", ex_helpclose,
- EX_RANGE|EX_COUNT|EX_TRLBAR,
- ADDR_OTHER),
+ EX_TRLBAR,
+ ADDR_NONE),
EXCMD(CMD_helpfind, "helpfind", ex_helpfind,
EX_EXTRA|EX_NOTRLCOM,
ADDR_NONE),
diff --git a/src/testdir/test_help.vim b/src/testdir/test_help.vim
index 820338abd..33e5234b5 100644
--- a/src/testdir/test_help.vim
+++ b/src/testdir/test_help.vim
@@ -58,6 +58,13 @@ func Test_help_errors()
bwipe!
endfunc
+func Test_helpclose_errors()
+ call assert_fails('42helpclose', 'E481:')
+ call assert_fails('helpclose 42', 'E488:')
+ call assert_fails('helpclose foo', 'E488:')
+ call assert_fails('helpclose!', 'E477:')
+endfunc
+
func Test_help_expr()
help expr-!~?
call assert_equal('eval.txt', expand('%:t'))
diff --git a/src/version.c b/src/version.c
index 5c19e6baa..d62c453f1 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1979,
/**/
1978,
/**/
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/vim_dev/E1vUoHQ-00EqYB-D6%40256bit.org.
