patch 9.1.1983: Vim9: class_name definition can be improved
Commit:
https://github.com/vim/vim/commit/2019321e0be320183afa47b7ea979dc4fc3984a0
Author: John Marriott <[email protected]>
Date: Mon Dec 15 21:09:29 2025 +0100
patch 9.1.1983: Vim9: class_name definition can be improved
Problem: Vim9: class_name definition can be improved
Solution: Use string_T to store class_name, avoid using STRLEN() calls,
simplify code, remove unused definition of struct
oc_newmember_S (John Marriott)
Use struct string_T to store the field class_name in struct class_T,
which means we can just use the .length field in struct string_T
instead of measuring it.
In addition:
1. In eval.c use string_T to store class_name and s in function
class_tv2string().
2. In vim9type.c change some calls from ga_concat() to ga_concat_len()
where the length is known.
3. In vim9class.c remove unused struct definition oc_newmember_S.
Change some calls from ga_concat() to ga_concat_len() where the
length is known.
4. In scriptfile.c use string_T to store type_name, class_name and
es_name in function estack_sfile().
5. In function estack_sfile() simplify construction of the grow array ga
and change some calls from ga_concat() to ga_concat_len() when the
length is known.
closes: #18925
Signed-off-by: John Marriott <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
diff --git a/src/eval.c b/src/eval.c
index 3f400c975..147d9980f 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -1156,7 +1156,7 @@ fill_lval_from_lval_root(lval_T *lp, lval_root_T *lr)
lp->ll_tv = &lp->ll_class->class_members_tv[m_idx];
#ifdef LOG_LOCKVAR
ch_log(NULL, "LKVAR: ... class member %s.%s",
- lp->ll_class->class_name, lp->ll_name);
+ lp->ll_class->class_name.string,
lp->ll_name);
#endif
return;
}
@@ -1205,7 +1205,7 @@ get_lval_check_access(
{
if (om->ocm_type->tt_type == VAR_OBJECT)
semsg(_(e_enumvalue_str_cannot_be_modified),
- cl->class_name, om->ocm_name);
+ cl->class_name.string, om->ocm_name);
else
msg = e_variable_is_not_writable_str;
}
@@ -6230,7 +6230,7 @@ method_tv2string(typval_T *tv, char_u **tofree, int
echo_style)
size_t len = vim_snprintf((char *)buf, sizeof(buf), "<SNR>%d_%s.%s",
pt->pt_func->uf_script_ctx.sc_sid,
- pt->pt_func->uf_class->class_name,
+ pt->pt_func->uf_class->class_name.string,
pt->pt_func->uf_name);
if (len >= sizeof(buf))
{
@@ -6493,31 +6493,29 @@ class_tv2string(typval_T *tv, char_u **tofree)
char_u *r = NULL;
size_t rsize;
class_T *cl = tv->vval.v_class;
- char_u *class_name = (char_u *)"[unknown]";
- size_t class_namelen = 9;
- char *s = "class";
- size_t slen = 5;
+ string_T class_name = {(char_u *)"[unknown]", 9};
+ string_T s = {(char_u *)"class", 5};
if (cl != NULL)
{
- class_name = cl->class_name;
- class_namelen = STRLEN(cl->class_name);
+ class_name.string = cl->class_name.string;
+ class_name.length = cl->class_name.length;
if (IS_INTERFACE(cl))
{
- s = "interface";
- slen = 9;
+ s.string = (char_u *)"interface";
+ s.length = 9;
}
else if (IS_ENUM(cl))
{
- s = "enum";
- slen = 4;
+ s.string = (char_u *)"enum";
+ s.length = 4;
}
}
- rsize = slen + 1 + class_namelen + 1;
+ rsize = s.length + 1 + class_name.length + 1;
r = *tofree = alloc(rsize);
if (r != NULL)
- vim_snprintf((char *)r, rsize, "%s %s", s, (char *)class_name);
+ vim_snprintf((char *)r, rsize, "%s %s", s.string, (char
*)class_name.string);
return r;
}
@@ -6550,11 +6548,11 @@ object_tv2string(
else if (copyID != 0 && obj->obj_copyID == copyID
&& obj->obj_class->class_obj_member_count != 0)
{
- size_t n = 25 + STRLEN((char *)obj->obj_class->class_name);
+ size_t n = 25 + obj->obj_class->class_name.length;
r = alloc(n);
if (r != NULL)
(void)vim_snprintf((char *)r, n, "object of %s {...}",
- obj->obj_class->class_name);
+
obj->obj_class->class_name.string);
*tofree = r;
}
else
diff --git a/src/evalvars.c b/src/evalvars.c
index af14c8b0d..2e0108534 100644
--- a/src/evalvars.c
+++ b/src/evalvars.c
@@ -2258,7 +2258,7 @@ report_lockvar_member(char *msg, lval_T *lp)
int did_alloc = FALSE;
char_u *vname = (char_u *)"";
char_u *class_name = lp->ll_class != NULL
- ? lp->ll_class->class_name : (char_u *)"";
+ ? lp->ll_class->class_name.string : (char_u
*)"";
if (lp->ll_name != NULL)
{
if (lp->ll_name_end == NULL)
diff --git a/src/scriptfile.c b/src/scriptfile.c
index 26616fd63..13bb8177c 100644
--- a/src/scriptfile.c
+++ b/src/scriptfile.c
@@ -188,51 +188,65 @@ estack_sfile(estack_arg_T which UNUSED)
entry = ((estack_T *)exestack.ga_data) + idx;
if (entry->es_name != NULL)
{
- long lnum = 0;
- char_u *type_name = (char_u *)"";
- char_u *class_name = (char_u *)"";
+ long lnum = 0;
+ string_T type_name = {(char_u *)"", 0};
+ string_T class_name = {(char_u *)"", 0};
+ string_T es_name = {entry->es_name, STRLEN(entry->es_name)};
if (entry->es_type != last_type)
{
switch (entry->es_type)
{
- case ETYPE_SCRIPT: type_name = (char_u *)"script "; break;
- case ETYPE_UFUNC: type_name = (char_u *)"function "; break;
- default: type_name = (char_u *)""; break;
+ case ETYPE_SCRIPT:
+ type_name.string = (char_u *)"script ";
+ type_name.length = 7;
+ break;
+ case ETYPE_UFUNC:
+ type_name.string = (char_u *)"function ";
+ type_name.length = 9;
+ break;
+ default:
+ break;
}
last_type = entry->es_type;
}
if (entry->es_type == ETYPE_UFUNC && entry->es_info.ufunc->uf_class
!= NULL)
- class_name = entry->es_info.ufunc->uf_class->class_name;
+ {
+ class_name.string =
entry->es_info.ufunc->uf_class->class_name.string;
+ class_name.length =
entry->es_info.ufunc->uf_class->class_name.length;
+ }
if (idx == exestack.ga_len - 1)
lnum = which == ESTACK_STACK ? SOURCING_LNUM : 0;
else
lnum = entry->es_lnum;
- len = STRLEN(entry->es_name) + STRLEN(type_name) +
STRLEN(class_name) + 26;
+
+ len = es_name.length + type_name.length + class_name.length + 26;
if (ga_grow(&ga, (int)len) == FAIL)
break;
- ga_concat(&ga, type_name);
- if (*class_name != NUL)
- {
- // For class methods prepend "<class name>." to the function
name.
- ga_concat(&ga, (char_u *)"<SNR>");
- ga.ga_len += vim_snprintf((char *)ga.ga_data + ga.ga_len, 23,
- "%d_", entry->es_info.ufunc->uf_script_ctx.sc_sid);
- ga_concat(&ga, class_name);
- ga_append(&ga, '.');
- }
- ga_concat(&ga, entry->es_name);
+ ga_concat_len(&ga, type_name.string, type_name.length);
+ // For class methods prepend "<class name>." to the function name.
+ if (*class_name.string != NUL)
+ ga.ga_len += vim_snprintf_safelen(
+ (char *)ga.ga_data + ga.ga_len,
+ len - (size_t)ga.ga_len,
+ "<SNR>%d_%s.",
+ entry->es_info.ufunc->uf_script_ctx.sc_sid,
+ class_name.string);
+ ga_concat_len(&ga, es_name.string, es_name.length);
// For the bottom entry of <sfile>: do not add the line number, it
is used in
// <slnum>. Also leave it out when the number is not set.
if (lnum != 0)
- ga.ga_len += vim_snprintf((char *)ga.ga_data + ga.ga_len, 23,
"[%ld]",
- lnum);
+ ga.ga_len += vim_snprintf_safelen(
+ (char *)ga.ga_data + ga.ga_len,
+ len - (size_t)ga.ga_len,
+ "[%ld]",
+ lnum);
if (idx != exestack.ga_len - 1)
- ga_concat(&ga, (char_u *)"..");
+ ga_concat_len(&ga, (char_u *)"..", 2);
}
}
- ga_append(&ga, '
+ ga_append(&ga, NUL);
return (char_u *)ga.ga_data;
#endif
}
diff --git a/src/structs.h b/src/structs.h
index b0969f782..43981b99e 100644
--- a/src/structs.h
+++ b/src/structs.h
@@ -1606,7 +1606,7 @@ struct itf2class_S {
// Also used for an interface (class_flags has CLASS_INTERFACE).
struct class_S
{
- char_u *class_name; // allocated
+ string_T class_name; // allocated
int class_flags; // CLASS_ flags
int class_refcount;
diff --git a/src/typval.c b/src/typval.c
index b6e1a9cc7..945f76320 100644
--- a/src/typval.c
+++ b/src/typval.c
@@ -283,7 +283,7 @@ tv_get_bool_or_number_chk(
{
class_T *cl = varp->vval.v_object->obj_class;
if (cl != NULL && IS_ENUM(cl))
- semsg(_(e_using_enum_str_as_number), cl->class_name);
+ semsg(_(e_using_enum_str_as_number),
cl->class_name.string);
else
emsg(_(e_using_object_as_number));
}
@@ -1248,7 +1248,7 @@ tv_get_string_buf_chk_strict(typval_T *varp, char_u *buf,
int strict)
{
class_T *cl = varp->vval.v_object->obj_class;
if (cl != NULL && IS_ENUM(cl))
- semsg(_(e_using_enum_str_as_string), cl->class_name);
+ semsg(_(e_using_enum_str_as_string),
cl->class_name.string);
else
emsg(_(e_using_object_as_string));
}
diff --git a/src/userfunc.c b/src/userfunc.c
index 6d8933be6..44c70e1ce 100644
--- a/src/userfunc.c
+++ b/src/userfunc.c
@@ -4524,7 +4524,8 @@ trans_function_name_ext(
else if (lv.ll_tv->v_type == VAR_CLASS
&& lv.ll_tv->vval.v_class != NULL)
{
- name = vim_strsave(lv.ll_tv->vval.v_class->class_name);
+ name = vim_strnsave(lv.ll_tv->vval.v_class->class_name.string,
+ lv.ll_tv->vval.v_class->class_name.length);
*pp = end;
}
else if (lv.ll_tv->v_type == VAR_PARTIAL
@@ -5955,7 +5956,7 @@ defcompile_function(ufunc_T *ufunc, class_T *cl)
(void)compile_def_function(ufunc, FALSE, compile_type, NULL);
else
smsg(_("Function %s%s%s does not need compiling"),
- cl != NULL ? cl->class_name : (char_u *)"",
+ cl != NULL ? cl->class_name.string : (char_u
*)"",
cl != NULL ? (char_u *)"." : (char_u *)"",
ufunc->uf_name);
}
diff --git a/src/version.c b/src/version.c
index a3e2f5127..e1ea81c6b 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1983,
/**/
1982,
/**/
diff --git a/src/vim9class.c b/src/vim9class.c
index d5c3615dc..d6a579cad 100644
--- a/src/vim9class.c
+++ b/src/vim9class.c
@@ -155,19 +155,6 @@ parse_member(
return OK;
}
-typedef struct oc_newmember_S oc_newmember_T;
-struct oc_newmember_S
-{
- garray_T *gap;
- char_u *varname;
- char_u *varname_end;
- int has_public;
- int has_final;
- int has_type;
- type_T *type;
- char_u *init_expr;
-};
-
/*
* Add a member to an object or a class.
* Returns OK when successful, "init_expr" will be consumed then.
@@ -260,7 +247,7 @@ object_index_from_itf_index(class_T *itf, int is_method,
int idx, class_T *cl)
if (idx >= (is_method ? itf->class_obj_method_count
: itf->class_obj_member_count))
{
- siemsg("index %d out of range for interface %s", idx, itf->class_name);
+ siemsg("index %d out of range for interface %s", idx,
itf->class_name.string);
return 0;
}
@@ -293,7 +280,7 @@ object_index_from_itf_index(class_T *itf, int is_method,
int idx, class_T *cl)
if (i2c == NULL)
{
siemsg("class %s not found on interface %s",
- cl->class_name, itf->class_name);
+ cl->class_name.string,
itf->class_name.string);
return 0;
}
@@ -319,7 +306,7 @@ validate_extends_class(
typval_T tv;
int success = FALSE;
- if (STRCMP(cl->class_name, extends_name) == 0)
+ if (STRCMP(cl->class_name.string, extends_name) == 0)
{
semsg(_(e_cannot_extend_str), extends_name);
return success;
@@ -376,7 +363,7 @@ validate_extends_generic_method(
else
msg = e_generic_method_str_type_arguments_mismatch_in_class_str;
- semsg(_(msg), cl_fp->uf_name, super_cl->class_name);
+ semsg(_(msg), cl_fp->uf_name, super_cl->class_name.string);
return FALSE;
}
@@ -426,7 +413,7 @@ validate_extends_methods(
// Method access is different between the super class
// and the subclass
semsg(_(e_method_str_of_class_str_has_different_access),
- cl_fp[j]->uf_name, super->class_name);
+ cl_fp[j]->uf_name, super->class_name.string);
return FALSE;
}
@@ -916,7 +903,7 @@ add_interface_from_super_class(
char_u *intf_name;
// Add the interface name to "impl_gap"
- intf_name = vim_strsave(ifcl->class_name);
+ intf_name = vim_strnsave(ifcl->class_name.string, ifcl->class_name.length);
if (intf_name == NULL)
return FALSE;
@@ -1723,11 +1710,11 @@ enum_parse_values(
if (init_expr == NULL)
vim_snprintf(initexpr_buf, sizeof(initexpr_buf), "%s.new()",
- en->class_name);
+ en->class_name.string);
else
{
vim_snprintf(initexpr_buf, sizeof(initexpr_buf), "%s.new%s",
- en->class_name, init_expr);
+ en->class_name.string, init_expr);
vim_free(init_expr);
}
if (add_member(gap, eni_name_start, eni_name_end, FALSE,
@@ -1793,18 +1780,18 @@ enum_add_values_member(
int rc = FAIL;
ga_init2(&fga, 1, 1000);
- ga_concat(&fga, (char_u *)"[");
+ ga_concat_len(&fga, (char_u *)"[", 1);
for (int i = 0; i < num_enum_values; ++i)
{
ocmember_T *m = ((ocmember_T *)gap->ga_data) + i;
if (i > 0)
- ga_concat(&fga, (char_u *)", ");
- ga_concat(&fga, en->class_name);
- ga_concat(&fga, (char_u *)".");
+ ga_concat_len(&fga, (char_u *)", ", 2);
+ ga_concat_len(&fga, en->class_name.string, en->class_name.length);
+ ga_concat_len(&fga, (char_u *)".", 1);
ga_concat(&fga, (char_u *)m->ocm_name);
}
- ga_concat(&fga, (char_u *)"]");
+ ga_concat_len(&fga, (char_u *)"]", 1);
ga_append(&fga, NUL);
char_u *varname = (char_u *)"values";
@@ -1822,7 +1809,7 @@ enum_add_values_member(
}
rc = add_member(gap, varname, varname + 6, FALSE, FALSE, TRUE, TRUE, type,
- vim_strsave((char_u *)fga.ga_data));
+ vim_strnsave((char_u *)fga.ga_data,
fga.ga_len));
done:
vim_free(fga.ga_data);
@@ -2078,8 +2065,9 @@ early_ret:
cl->class_flags = CLASS_ABSTRACT;
cl->class_refcount = 1;
- cl->class_name = vim_strnsave(name_start, name_end - name_start);
- if (cl->class_name == NULL)
+ cl->class_name.length = (size_t)(name_end - name_start);
+ cl->class_name.string = vim_strnsave(name_start, cl->class_name.length);
+ if (cl->class_name.string == NULL)
goto cleanup;
cl->class_type.tt_type = VAR_CLASS;
@@ -2094,7 +2082,7 @@ early_ret:
tv.v_type = VAR_CLASS;
tv.vval.v_class = cl;
SOURCING_LNUM = start_lnum;
- int rc = set_var_const(cl->class_name, 0, NULL, &tv, FALSE, 0, 0);
+ int rc = set_var_const(cl->class_name.string, 0, NULL, &tv, FALSE, 0, 0);
if (rc == FAIL)
goto cleanup;
@@ -3012,7 +3000,7 @@ call_oc_method(
{
// Protected object or class funcref variable
semsg(_(e_cannot_access_protected_variable_str), ocm->ocm_name,
- cl->class_name);
+ cl->class_name.string);
return FAIL;
}
@@ -3570,7 +3558,7 @@ oc_var_check_ro(class_T *cl, ocmember_T *m)
if (m->ocm_flags & (OCMFLAG_FINAL | OCMFLAG_CONST))
{
semsg(_(e_cannot_change_readonly_variable_str_in_class_str),
- m->ocm_name, cl->class_name);
+ m->ocm_name, cl->class_name.string);
return TRUE;
}
return FALSE;
@@ -3633,7 +3621,7 @@ class_free(class_T *cl)
// Freeing what the class contains may recursively come back here.
// Clear "class_name" first, if it is NULL the class does not need to
// be freed.
- VIM_CLEAR(cl->class_name);
+ VIM_CLEAR_STRING(cl->class_name);
class_unref(cl->class_extends);
@@ -3795,7 +3783,7 @@ class_unref(class_T *cl)
--cl->class_refcount;
- if (cl->class_name == NULL)
+ if (cl->class_name.string == NULL)
return;
if (can_free_class(cl))
@@ -3966,7 +3954,7 @@ emsg_var_cl_define(char *msg, char_u *name, size_t len,
class_T *cl)
ocmember_T *m;
class_T *cl_def = class_defining_member(cl, name, len, &m);
if (cl_def != NULL)
- semsg(_(msg), m->ocm_name, cl_def->class_name);
+ semsg(_(msg), m->ocm_name, cl_def->class_name.string);
else
emsg(_(e_internal_error_please_report_a_bug));
}
@@ -3986,7 +3974,7 @@ method_not_found_msg(class_T *cl, vartype_T v_type,
char_u *name, size_t len)
semsg(_(e_cannot_access_protected_method_str), method_name);
else
semsg(_(e_class_method_str_accessible_only_using_class_str),
- method_name, cl->class_name);
+ method_name, cl->class_name.string);
}
else if ((v_type == VAR_CLASS)
&& (object_method_idx(cl, name, len) >= 0))
@@ -3996,11 +3984,11 @@ method_not_found_msg(class_T *cl, vartype_T v_type,
char_u *name, size_t len)
semsg(_(e_cannot_access_protected_method_str), method_name);
else
semsg(_(e_object_method_str_accessible_only_using_object_str),
- method_name, cl->class_name);
+ method_name, cl->class_name.string);
}
else
semsg(_(e_method_not_found_on_class_str_str), method_name,
- cl->class_name);
+ cl->class_name.string);
vim_free(method_name);
}
@@ -4016,24 +4004,24 @@ member_not_found_msg(class_T *cl, vartype_T v_type,
char_u *name, size_t len)
{
if (class_member_idx(cl, name, len) >= 0)
semsg(_(e_class_variable_str_accessible_only_using_class_str),
- varname, cl->class_name);
+ varname, cl->class_name.string);
else
semsg(_(e_variable_not_found_on_object_str_str), varname,
- cl->class_name);
+ cl->class_name.string);
}
else
{
if (object_member_idx(cl, name, len) >= 0)
semsg(_(e_object_variable_str_accessible_only_using_object_str),
- varname, cl->class_name);
+ varname, cl->class_name.string);
else
{
if (IS_ENUM(cl))
semsg(_(e_enum_value_str_not_found_in_enum_str),
- varname, cl->class_name);
+ varname, cl->class_name.string);
else
semsg(_(e_class_variable_str_not_found_in_class_str),
- varname, cl->class_name);
+ varname, cl->class_name.string);
}
}
vim_free(varname);
@@ -4068,7 +4056,7 @@ defcompile_classes_in_script(void)
{
for (class_T *cl = first_class; cl != NULL; cl = cl->class_next_used)
{
- if (eval_variable(cl->class_name, 0, 0, NULL, NULL,
+ if (eval_variable(cl->class_name.string, 0, 0, NULL, NULL,
EVAL_VAR_NOAUTOLOAD | EVAL_VAR_NO_FUNC) != FAIL)
defcompile_class(cl);
}
@@ -4215,28 +4203,30 @@ object2string(
if (cl != NULL && IS_ENUM(cl))
{
- ga_concat(&ga, (char_u *)"enum ");
- ga_concat(&ga, cl->class_name);
+ ga_concat_len(&ga, (char_u *)"enum ", 5);
+ ga_concat_len(&ga, cl->class_name.string, cl->class_name.length);
char_u *enum_name = ((typval_T *)(obj + 1))->vval.v_string;
- ga_concat(&ga, (char_u *)".");
+ ga_concat_len(&ga, (char_u *)".", 1);
ga_concat(&ga, enum_name);
}
else
{
- ga_concat(&ga, (char_u *)"object of ");
- ga_concat(&ga, cl == NULL ? (char_u *)"[unknown]"
- : cl->class_name);
+ ga_concat_len(&ga, (char_u *)"object of ", 10);
+ if (cl == NULL)
+ ga_concat_len(&ga, (char_u *)"[unknown]", 9);
+ else
+ ga_concat_len(&ga, cl->class_name.string, cl->class_name.length);
}
if (cl != NULL)
{
- ga_concat(&ga, (char_u *)" {");
+ ga_concat_len(&ga, (char_u *)" {", 2);
for (int i = 0; i < cl->class_obj_member_count; ++i)
{
if (i > 0)
- ga_concat(&ga, (char_u *)", ");
+ ga_concat_len(&ga, (char_u *)", ", 2);
ocmember_T *m = &cl->class_obj_members[i];
ga_concat(&ga, m->ocm_name);
- ga_concat(&ga, (char_u *)": ");
+ ga_concat_len(&ga, (char_u *)": ", 2);
char_u *tf = NULL;
char_u *s = echo_string_core((typval_T *)(obj + 1) + i,
&tf, numbuf, copyID, echo_style,
@@ -4251,7 +4241,7 @@ object2string(
}
line_breakcheck();
}
- ga_concat(&ga, (char_u *)"}");
+ ga_concat_len(&ga, (char_u *)"}", 1);
}
if (ok == FAIL)
{
diff --git a/src/vim9cmds.c b/src/vim9cmds.c
index d06759e80..8a1ab80cd 100644
--- a/src/vim9cmds.c
+++ b/src/vim9cmds.c
@@ -248,8 +248,8 @@ compile_lock_unlock(
if (*end != '.' && *end != '[')
{
// Push the class of the bare class variable name
- name = cl->class_name;
- len = (int)STRLEN(name);
+ name = cl->class_name.string;
+ len = (int)cl->class_name.length;
#ifdef LOG_LOCKVAR
ch_log(NULL, "LKVAR: ... cctx_class_member: name %s",
name);
diff --git a/src/vim9compile.c b/src/vim9compile.c
index 43f8dcb7f..db4ef9288 100644
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -1627,7 +1627,7 @@ lhs_class_member_modifiable(lhs_T *lhs, char_u
*var_start, cctx_T *cctx)
if (IS_ENUM(cl))
{
- semsg(_(e_enumvalue_str_cannot_be_modified), cl->class_name,
+ semsg(_(e_enumvalue_str_cannot_be_modified), cl->class_name.string,
m->ocm_name);
return FALSE;
}
@@ -1758,7 +1758,7 @@ compile_lhs_class_variable(
// A class variable can be accessed without the class name
// only inside a class.
semsg(_(e_class_variable_str_accessible_only_inside_class_str),
- lhs->lhs_name, defcl->class_name);
+ lhs->lhs_name, defcl->class_name.string);
return FAIL;
}
@@ -2055,7 +2055,7 @@ compile_lhs_set_oc_member_type(
if (!inside_class(cctx, cl))
{
semsg(_(e_enumvalue_str_cannot_be_modified),
- cl->class_name, m->ocm_name);
+ cl->class_name.string, m->ocm_name);
return FAIL;
}
if (lhs->lhs_type->tt_type == VAR_OBJECT &&
@@ -2064,7 +2064,7 @@ compile_lhs_set_oc_member_type(
char *msg = lhs->lhs_member_idx == 0 ?
e_enum_str_name_cannot_be_modified :
e_enum_str_ordinal_cannot_be_modified;
- semsg(_(msg), cl->class_name);
+ semsg(_(msg), cl->class_name.string);
return FAIL;
}
}
diff --git a/src/vim9execute.c b/src/vim9execute.c
index 13334e58e..419f30372 100644
--- a/src/vim9execute.c
+++ b/src/vim9execute.c
@@ -3345,7 +3345,7 @@ var_any_get_oc_member(class_T *current_class, isn_T
*iptr, typval_T *tv)
msg = e_variable_not_found_on_object_str_str;
else
msg = e_class_variable_str_not_found_in_class_str;
- semsg(_(msg), iptr->isn_arg.string, tv_cl->class_name);
+ semsg(_(msg), iptr->isn_arg.string, tv_cl->class_name.string);
return FAIL;
}
@@ -7069,7 +7069,7 @@ list_instructions(char *pfx, isn_T *instr, int
instr_count, ufunc_T *ufunc)
{
case ISN_CONSTRUCT:
smsg("%s%4d NEW %s size %d", pfx, current,
- iptr->isn_arg.construct.construct_class->class_name,
+
iptr->isn_arg.construct.construct_class->class_name.string,
(int)iptr->isn_arg.construct.construct_size);
break;
case ISN_EXEC:
@@ -7381,7 +7381,7 @@ list_instructions(char *pfx, isn_T *instr, int
instr_count, ufunc_T *ufunc)
smsg("%s%4d %s CLASSMEMBER %s.%s", pfx, current,
iptr->isn_type == ISN_LOAD_CLASSMEMBER
? "LOAD" : "STORE",
- cl->class_name, ocm->ocm_name);
+ cl->class_name.string, ocm->ocm_name);
}
break;
@@ -7436,7 +7436,7 @@ list_instructions(char *pfx, isn_T *instr, int
instr_count, ufunc_T *ufunc)
case ISN_PUSHCLASS:
smsg("%s%4d PUSHCLASS %s", pfx, current,
iptr->isn_arg.classarg == NULL ? "null"
- : (char *)iptr->isn_arg.classarg->class_name);
+ : (char
*)iptr->isn_arg.classarg->class_name.string);
break;
case ISN_PUSHEXC:
smsg("%s%4d PUSH v:exception", pfx, current);
@@ -7508,7 +7508,7 @@ list_instructions(char *pfx, isn_T *instr, int
instr_count, ufunc_T *ufunc)
cmfunc_T *mfunc = iptr->isn_arg.mfunc;
smsg("%s%4d METHODCALL %s.%s(argc %d)", pfx, current,
- mfunc->cmf_itf->class_name,
+ mfunc->cmf_itf->class_name.string,
mfunc->cmf_itf->class_obj_methods[
mfunc->cmf_idx]->uf_name,
mfunc->cmf_argcount);
@@ -7563,7 +7563,7 @@ list_instructions(char *pfx, isn_T *instr, int
instr_count, ufunc_T *ufunc)
if (extra != NULL && extra->fre_class != NULL)
{
smsg("%s%4d FUNCREF %s.%s", pfx, current,
- extra->fre_class->class_name, name);
+ extra->fre_class->class_name.string,
name);
}
else if (extra == NULL
|| extra->fre_loopvar_info.lvi_depth == 0)
@@ -7853,7 +7853,7 @@ list_instructions(char *pfx, isn_T *instr, int
instr_count, ufunc_T *ufunc)
case ISN_GET_ITF_MEMBER: smsg("%s%4d ITF_MEMBER %d on %s",
pfx, current,
(int)iptr->isn_arg.classmember.cm_idx,
- iptr->isn_arg.classmember.cm_class->class_name);
+
iptr->isn_arg.classmember.cm_class->class_name.string);
break;
case ISN_STORE_THIS: smsg("%s%4d STORE_THIS %d", pfx, current,
(int)iptr->isn_arg.number); break;
diff --git a/src/vim9expr.c b/src/vim9expr.c
index f692eeff3..3676dabe1 100644
--- a/src/vim9expr.c
+++ b/src/vim9expr.c
@@ -496,7 +496,7 @@ compile_class_object_index(cctx_T *cctx, char_u **arg,
type_T *type)
// Trying to invoke an abstract method in a super class is not
// allowed.
semsg(_(e_abstract_method_str_direct), ufunc->uf_name,
- ufunc->uf_defclass->class_name);
+ ufunc->uf_defclass->class_name.string);
goto done;
}
@@ -1052,7 +1052,7 @@ compile_load(
else
{
semsg(_(e_class_variable_str_accessible_only_inside_class_str),
- name, cl->class_name);
+ name, cl->class_name.string);
res = FAIL;
}
}
@@ -1511,7 +1511,7 @@ compile_call(
else
{
semsg(_(e_class_method_str_accessible_only_inside_class_str),
- name, cl->class_name);
+ name, cl->class_name.string);
res = FAIL;
}
goto theend;
diff --git a/src/vim9type.c b/src/vim9type.c
index 0d275b3a9..6d1b28afd 100644
--- a/src/vim9type.c
+++ b/src/vim9type.c
@@ -2626,23 +2626,27 @@ failed:
static char *
type_name_class_or_obj(char *name, type_T *type, char **tofree)
{
- char_u *class_name;
+ string_T class_name;
if (type->tt_class != NULL)
{
- class_name = type->tt_class->class_name;
+ class_name.string = type->tt_class->class_name.string;
+ class_name.length = type->tt_class->class_name.length;
if (IS_ENUM(type->tt_class))
name = "enum";
}
else
- class_name = (char_u *)"any";
+ {
+ class_name.string = (char_u *)"any";
+ class_name.length = 3;
+ }
- size_t len = STRLEN(name) + STRLEN(class_name) + 3;
+ size_t len = STRLEN(name) + class_name.length + 3;
*tofree = alloc(len);
if (*tofree == NULL)
return name;
- vim_snprintf(*tofree, len, "%s<%s>", name, class_name);
+ vim_snprintf(*tofree, len, "%s<%s>", name, class_name.string);
return *tofree;
}
@@ -2812,7 +2816,7 @@ check_typval_is_value(typval_T *tv)
{
class_T *cl = tv->vval.v_class;
char_u *class_name = (cl == NULL) ? (char_u *)""
- : cl->class_name;
+ : cl->class_name.string;
if (cl != NULL && IS_ENUM(cl))
semsg(_(e_using_enum_as_value_str), class_name);
else
@@ -2844,11 +2848,11 @@ check_type_is_value(type_T *type)
case VAR_CLASS:
if (type->tt_class != NULL && IS_ENUM(type->tt_class))
semsg(_(e_using_enum_as_value_str),
- type->tt_class->class_name);
+ type->tt_class->class_name.string);
else
semsg(_(e_using_class_as_value_str),
type->tt_class == NULL ? (char_u *)""
- : type->tt_class->class_name);
+ : type->tt_class->class_name.string);
return FAIL;
case VAR_TYPEALIAS:
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/vim_dev/E1vVFCm-00GsQT-55%40256bit.org.
