On 12/29/2015 02:37 PM, Dylan Baker wrote: > Okay, I can fix that too. > > On Sun, Dec 27, 2015 at 7:43 AM, Frank Henigman <fjhenig...@google.com > <mailto:fjhenig...@google.com>> wrote: > > On Wed, Dec 16, 2015 at 8:37 PM, <baker.dyla...@gmail.com > <mailto:baker.dyla...@gmail.com>> wrote: > > From: Dylan Baker <baker.dyla...@gmail.com > <mailto:baker.dyla...@gmail.com>> > > > > Pull these out into helper functions, this change will be used in a > > following patch to add a json printer. > > > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com > <mailto:dylanx.c.ba...@intel.com>> > > --- > > src/utils/wflinfo.c | 50 > ++++++++++++++++++++++++++++++++++++-------------- > > 1 file changed, 36 insertions(+), 14 deletions(-)
> > + const char * vendor = get_vendor(); > > + const char * renderer = get_renderer(); > > + const char * version_str = get_version(); > > nit: usually no space after * Yes. The convention in Waffle is ``const char *vendor``. Other than that, the patch looks good. _______________________________________________ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle
